Closed MrCode97 closed 3 weeks ago
current state is deployed for review at test.advents-calendar.org
See: b8c8066586d682e19acc0fb81b065c2d75d532e7
frontend/src/components/LangBadge.tsx
frontend/src/components/LangFlag.tsx
frontend/src/components/NavigationBar.tsx:106
frontend/src/components/AdventToolbar.tsx:58
frontend/src/components/UserRegistrationForm.js
Prefer the LangFlag
-switch and position AdventToolbar.tsx:58
, but let me know you think?
Regarding warnings:
src/App.js Line 66:27: 'setShowMyCalendars' is assigned a value but never used no-unused-vars
Contrary to the warning, used in both NavigationBar
and AdventToolbar
(but not in App.js
- result of factoring)LangBadge
, LangFlag
imports - as soon as we decided on a switch and position, I'll remove the unused imports and they should go away.current state is deployed for review at test.advents-calendar.org cool:
Most functionality is there, still to fix is:
react__WEBPACK_IMPORTED_MODULE_0__.useContext(...).public.assets is undefined
App.js
.Things to check:
de-DE.json
,en-US.json
in the right pathpublic/lang/
and is thedefault.json
not interfering ?let
and reload / overwrite with new language, orApp.js
. In that case, need to make sure that the default-logic does not overwrite the language-switch if we reload.I.e. I started this:
so we could read/set the
lang
in localStorage, if a user makes an intend language change. Note, only if nothing is set, we considernavigator.language
.@luechtdiode if you have the time and energy, I'd appreciate you working this out. As you already introduced this text-injection within the Impressum, I think you'll get there faster. Otherwise I'll fix it later.