search

MrCrayfish / Configured

The easiest way to change the configuration of mods!
https://www.curseforge.com/minecraft/mc-mods/configured
Other
62 stars 46 forks source link

[1.18] Crash when accessing ConfigScreen with nightconfigfixes #111

Open Tidy-Bear opened 11 months ago

Tidy-Bear commented 11 months ago

A code change is missing when merging Fuzss's compatibility PR into 1.18.X, which causes ClassCastException when initializing ConfigScreen with nightconfigfixes enabled.

Current (1.18.X): https://github.com/MrCrayfish/Configured/blob/df8f2748cdc90c35bea2e8f8405cbb9c8c329a24/src/main/java/com/mrcrayfish/configured/impl/forge/ForgeConfig.java#L87-L91

Expected (1.19.X): https://github.com/MrCrayfish/Configured/blob/43287a97063186351ed7184fb8ec9846ebb1f60c/src/main/java/com/mrcrayfish/configured/impl/forge/ForgeConfig.java#L86-L90

The issue seems to exist in multiloader/1.19.X, too.

Related issue: https://github.com/Fuzss/nightconfigfixes/issues/9