MrCrayfish / Configured

The easiest way to change the configuration of mods!
https://www.curseforge.com/minecraft/mc-mods/configured
Other
62 stars 46 forks source link

Fix crash parsing list entries #140

Open PersonTheCat opened 3 months ago

PersonTheCat commented 3 months ago

These changes resolve a crash when adding list entries due to NumberFormatExceptions (and other errors). I have chosen to resolve this by wrapping all parser functions with an error handler, guaranteeing that a crash can never occur, even with custom parsers. You may disagree with this or the choice to log suppressed exceptions, but I am open to feedback.

Confirmed fix in original project. No test coverage was needed (existing tests were failing)