search

MrCrayfish / Controllable

Adds in the ability to use a controller to play Minecraft Java Edition
https://mrcrayfish.com/mods?id=controllable
GNU General Public License v3.0
269 stars 77 forks source link

Vibrations no longer working on 0.10.1 #142

Open jadenPete opened 3 years ago

jadenPete commented 3 years ago

Hello, and thanks for all the work you've put into the new releases!

OS: Windows 10 64 bit Controller: Xbox Series X/S over Bluetooth Minecraft Version: 1.16.5 with Forge, OptiFine HD U G6, and WorldEdit Current Controllable version: 0.10.1 Last working Controllable version: 0.9.1

My controller no longer vibrates (e.g. when I raise my shield, eat, or fall), regardless of whether the setting is enabled. I think it may have to do with using GLFW to handle controller input.

EDIT: Apparently, GLFW doesn't support haptic feedback, though there is a pull request to add it.

MrCrayfish commented 3 years ago

Unfortunately as mentioned GLFW does not support rumble. I knew this before switching to GLFW but thought it was a good trade off to reduce the file size of the mod. I may consider bringing back SDL until GLFW adds rumble support. (Especially since the first issue was posted in 2013 for rumble support)

jadenPete commented 3 years ago

Though the reduced file size is nice, I would appreciate bringing back SDL (especially considering its other issues). Perhaps GLFW could be used in the future?

MrCrayfish commented 3 years ago

The issue referenced was reported before I implemented GLFW. I have a version of Controllable that can optionally load SDL but I don't know how to distribute the required libraries (3 different files).

jadenPete commented 3 years ago

Can you merge the libraries into the mod jar?

imarak2 commented 6 months ago

me too on the new version 0.20.3 it still doesn't work when i raise my shield or charge a bow i don't feel the rumble and i double checked the rumble to see if its on and it is on please comment when you can