[Suggestion] Add in the ability to hold down the attack button

[ExDrill]

Similar to the combat test snapshots and legacy console, there should be an ability to hold down the attack input and it should only swing the item when there is no cooldown.

[erazare]

agree needs to be done to allow Epic Combat / Better Combat

[MrCrayfish]

Since Controllable can be used on your client to play on vanilla servers, I Idealy want to keep Controllable safe for use on servers. Auto-attack is considered a cheat on most popular servers. I can't add it even as a config option that is off by default since the feature is still technically there.

[erazare]

guess its midnight controls for the win then folks seems it works just fine with them and they have no such caveat, just a note, once you add a mod, ANY MOD your install is no longer vanilla. As such, your reason given is bogus

[MrCrayfish]

I never said anything about your client still being vanilla even when you install a mod, but go on. Sorry for considering potential issues when it comes to implementing a feature in this mod. I am glad you won't use this mod.

[MrCrayfish]

I've reopened the issue in the case that Mojang adds an auto-attack feature in the future.

[erazare]

so.. you had a hissy-fit because someone pointed out the obvious to you, and then re-opened it anyway as you KNOW it's not right. first, you COULD make a purely "vanilla friendly" version if you like to comply with your delusion.. ( if a vanilla server doesnt want you to use mods, you shouldnt be advocating the use of mods the server cannot detect ) secondly, since modded servers WANT this ability you are denying the modding community.. you know the community you develop for? don't look at me because i am the voice of reason like many others before me, look to your own issues as opposed to childishly attacking others in response.

[MrCrayfish]

It's not that deep...

[MrCrayfish]

look to your own issues as opposed to childishly attacking others in response.

Giving a reason why the feature may not be added is not a "childish attack".

For reference, your immediate reply is

guess its midnight controls for the win then folks seems it works just fine with them and they have no such caveat, just a note, once you add a mod, ANY MOD your install is no longer vanilla. As such, your reason given is bogus.

I'd beg to differ to that mine are the childish ones. Firstly Midnight Controls doesn't have auto attack, secondly awarding them a "win" like their author is dismissing the potential issues of automation features. Players use our mods for a variety of reasons. A decent portion of those players use our mods to just to play vanilla content (only the controller mod installed), and it's likely that same player base will also take our mod into vanilla based servers, like Hypixel. It's still up to player to adhere by the rules of the server and mods should be used in good faith (detectable or not), however that doesn't mean I should just blindly add a feature like auto-attack without considering those use cases.

The fact that Mojang have experimented with auto attack is a great sign for the future and I'd love to make sure this mod supports it if and when it's added; this is why the issue was re-opened.

[erazare]

yeah whatever makes you feel better crayfish.. washing my hands of your mod and this chatline

On Sat, Feb 4, 2023 at 7:01 AM MrCrayfish @.***> wrote:

look to your own issues as opposed to childishly attacking others in response.

Giving a reason why the feature may not be added is not a "childish attack".

For reference, your immediate reply is

guess its midnight controls for the win then folks seems it works just fine with them and they have no such caveat, just a note, once you add a mod, ANY MOD your install is no longer vanilla. As such, your reason given is bogus.

I'd beg to differ to that mine are the childish ones. Firstly Midnight Controls doesn't have auto attack, secondly awarding them a "win" like their author is dismissing the potential issues of automation features. Players use our mods for a variety of reasons. A decent portion of those players use our mods to just to play vanilla content (only the controller mod installed), and it's likely that same player base will also take our mod into vanilla based servers, like Hypixel. It's still up to player to adhere by the rules of the server and mods should be used in good faith (detectable or not), however that doesn't mean I should just blindly add a feature like auto-attack without considering those use cases.

The fact that Mojang have experimented with auto attack is a great sign for the future and I'd love to make sure this mod supports it if and when it's added; this is why the issue was re-opened.

— Reply to this email directly, view it on GitHub https://github.com/MrCrayfish/Controllable/issues/356#issuecomment-1416734210, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWPQCKRL3MRF5AE73SGM3WVZAKNANCNFSM6AAAAAASM4ZNXQ . You are receiving this because you commented.Message ID: @.***>

--

Keith E Legge / 3raZar3

@.***>

[MrCrayfish]

Glad we could have a productive conversation, cya!

[SisterVersio]

Better Combat (a total overhaul of how weapons work in modded environments, not a cheat tool for vanilla servers) has a setting to continuously swing while holding down the mouse button. That setting is not functional with Controllable and is something I'd really like to see fixed. I don't think this needs to impact vanilla combat if implemented properly, as Controlify on fabric does not have auto-attack and simultaneously allows better combat to function as intended if installed (hold trigger to swing with better combat, repeatedly tap trigger to swing in vanilla). Controllable is the only functional controller mod for Forge 1.20.1 and I have been a little disappointed that this is unimplemented so far. Thanks