MrCrayfish / Controllable

Adds in the ability to use a controller to play Minecraft Java Edition
https://mrcrayfish.com/mods?id=controllable
GNU General Public License v3.0
268 stars 81 forks source link

Forge+OptiFine Not Allowing Me to Use Controllable & Framework On Minecraft Version 1.20.1 #433

Open iWockstar opened 1 year ago

iWockstar commented 1 year ago

Hello, I want to begin by saying I love the mod. As a controller user it's great being able to use a controller AND get to choose PlayStation button prompts. With this, I am having an issue when using Forge and OptiFine together and trying to add the mods controllable and framework. When adding controllable with framework, my game crashes on the red Mojang screen and I get exit code 1. I know this is a common issue, but I was wondering if controllable will ever be updated to work with OptiFine + Forge or if there's a some way to bypass this exit code. Thanks!

Gavinisawizard commented 1 year ago

same

MegPredator commented 1 year ago

Currently no fixes exist, you need to remove optifine and maybe use rubidium but it is not necessary of course

Trimatix commented 1 year ago

This is more of an Optifine issue than a Controllable issue. this page gives a nice summary: https://blog.minecraftforge.net/personal/matyrobbrt/optifine-alternatives/

Wh1rledPeas commented 1 year ago

same issue. Any ETA for a fix?

Queeq commented 1 year ago

Same issue. When Optifine and Controllable both used as Forge mods it crashes. Here's the log:


[13Aug2023 09:31:35.465] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, <cut>, --version, 1.20.1-forge-47.0.35, --gameDir, /home/family/.minecraft, --assetsDir, /home/family/.minecraft/assets, --assetIndex, 5, --uuid, <cut>, --accessToken, ❄❄❄❄❄❄❄❄, --clientId, <cut>, --xuid, <cut>, --userType, msa, --versionType, release, --launchTarget, forgeclient, --fml.forgeVersion, 47.0.35, --fml.mcVersion, 1.20.1, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20230612.114412]
[13Aug2023 09:31:35.469] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 10.0.9+10.0.9+main.dcd20f30 starting: java version 17.0.3 by Microsoft; OS Linux arch amd64 version 6.2.0-26-generic
[13Aug2023 09:31:35.598] [main/INFO] [net.minecraftforge.fml.loading.ImmediateWindowHandler/]: Loading ImmediateWindowProvider fmlearlywindow
[13Aug2023 09:31:35.669] [main/INFO] [EARLYDISPLAY/]: Trying GL version 4.6
[13Aug2023 09:31:35.765] [main/INFO] [EARLYDISPLAY/]: Requested GL version 4.6 got version 4.6
[13Aug2023 09:31:35.807] [main/INFO] [optifine.OptiFineTransformationService/]: OptiFineTransformationService.onLoad
[13Aug2023 09:31:35.807] [main/INFO] [optifine.OptiFineTransformationService/]: OptiFine ZIP file URL: union:/home/family/.minecraft/mods/optifine_1.20.1.jar%23149!/
[13Aug2023 09:31:35.811] [main/INFO] [optifine.OptiFineTransformationService/]: OptiFine ZIP file: /home/family/.minecraft/mods/optifine_1.20.1.jar
[13Aug2023 09:31:35.813] [main/INFO] [optifine.OptiFineTransformer/]: Target.PRE_CLASS is available
[13Aug2023 09:31:35.849] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/home/family/.minecraft/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%2388!/ Service=ModLauncher Env=CLIENT
[13Aug2023 09:31:35.855] [main/INFO] [optifine.OptiFineTransformationService/]: OptiFineTransformationService.initialize
[13Aug2023 09:31:35.874] [pool-2-thread-1/INFO] [EARLYDISPLAY/]: GL info: NVIDIA GeForce RTX 3070/PCIe/SSE2 GL version 4.6.0 NVIDIA 525.125.06, NVIDIA Corporation
[13Aug2023 09:31:36.063] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/family/.minecraft/libraries/net/minecraftforge/fmlcore/1.20.1-47.0.35/fmlcore-1.20.1-47.0.35.jar is missing mods.toml file
[13Aug2023 09:31:36.064] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/family/.minecraft/libraries/net/minecraftforge/javafmllanguage/1.20.1-47.0.35/javafmllanguage-1.20.1-47.0.35.jar is missing mods.toml file
[13Aug2023 09:31:36.065] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/family/.minecraft/libraries/net/minecraftforge/lowcodelanguage/1.20.1-47.0.35/lowcodelanguage-1.20.1-47.0.35.jar is missing mods.toml file
[13Aug2023 09:31:36.066] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/family/.minecraft/libraries/net/minecraftforge/mclanguage/1.20.1-47.0.35/mclanguage-1.20.1-47.0.35.jar is missing mods.toml file
[13Aug2023 09:31:36.394] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator/]: Found 1 dependencies adding them to mods collection
[13Aug2023 09:31:36.702] [main/INFO] [optifine.OptiFineTransformationService/]: OptiFineTransformationService.transformers
[13Aug2023 09:31:36.706] [main/INFO] [optifine.OptiFineTransformer/]: Targets: 411
[13Aug2023 09:31:36.937] [main/INFO] [optifine.OptiFineTransformationService/]: additionalClassesLocator: [optifine., net.optifine.]
[13Aug2023 09:31:37.121] [main/INFO] [mixin/]: Compatibility level set to JAVA_17
[13Aug2023 09:31:37.123] [main/INFO] [cpw.mods.modlauncher.LaunchServiceHandler/MODLAUNCHER]: Launching target 'forgeclient' with arguments [--version, 1.20.1-forge-47.0.35, --gameDir, /home/family/.minecraft, --assetsDir, /home/family/.minecraft/assets, --uuid, <cut>, --username, <cut>, --assetIndex, 5, --accessToken, ❄❄❄❄❄❄❄❄, --clientId, <cut>, --xuid, <cut>, --userType, msa, --versionType, release]
[13Aug2023 09:31:37.324] [main/WARN] [mixin/]: Error loading class: mezz/jei/gui/elements/GuiIconToggleButton (java.lang.ClassNotFoundException: mezz.jei.gui.elements.GuiIconToggleButton)
[13Aug2023 09:31:37.325] [main/WARN] [mixin/]: Error loading class: mezz/jei/gui/overlay/IngredientGrid (java.lang.ClassNotFoundException: mezz.jei.gui.overlay.IngredientGrid)
[13Aug2023 09:31:37.325] [main/WARN] [mixin/]: Error loading class: mezz/jei/gui/overlay/IngredientGridWithNavigation (java.lang.ClassNotFoundException: mezz.jei.gui.overlay.IngredientGridWithNavigation)
[13Aug2023 09:31:37.326] [main/WARN] [mixin/]: Error loading class: mezz/jei/gui/overlay/IngredientListOverlay (java.lang.ClassNotFoundException: mezz.jei.gui.overlay.IngredientListOverlay)
[13Aug2023 09:31:37.327] [main/WARN] [mixin/]: Error loading class: mezz/jei/gui/input/MouseUtil (java.lang.ClassNotFoundException: mezz.jei.gui.input.MouseUtil)
[13Aug2023 09:31:37.328] [main/WARN] [mixin/]: Error loading class: mezz/jei/gui/PageNavigation (java.lang.ClassNotFoundException: mezz.jei.gui.PageNavigation)
[13Aug2023 09:31:38.346] [main/ERROR] [mixin/]: Critical injection failure: LVT in net/minecraft/client/renderer/GameRenderer::m_109093_(FJZ)V has incompatible changes at opcode 769 in callback controllable.mixins.json:client.ForgeGameRendererMixin->@Inject::controllableLastRender(FJZLorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;IILcom/mojang/blaze3d/platform/Window;Lorg/joml/Matrix4f;Lcom/mojang/blaze3d/vertex/PoseStack;Lnet/minecraft/client/gui/GuiGraphics;)V.
 Expected: [I, I, Lcom/mojang/blaze3d/platform/Window;, Lorg/joml/Matrix4f;, Lcom/mojang/blaze3d/vertex/PoseStack;, Lnet/minecraft/client/gui/GuiGraphics;]
    Found: [I, I, Lcom/mojang/blaze3d/platform/Window;, F, Lorg/joml/Matrix4f;, Lcom/mojang/blaze3d/vertex/PoseStack;]
Available: [I, I, Lcom/mojang/blaze3d/platform/Window;, F, Lorg/joml/Matrix4f;, Lcom/mojang/blaze3d/vertex/PoseStack;, F, Lnet/minecraft/client/gui/GuiGraphics;, Ljava/lang/Throwable;, Lnet/minecraft/CrashReport;, Lnet/minecraft/CrashReportCategory;]
Queeq commented 1 year ago

Ah, this is duplicate with #418

Trimatix commented 1 year ago

This is more of an Optifine issue than a Controllable issue. this page gives a nice summary: https://blog.minecraftforge.net/personal/matyrobbrt/optifine-alternatives/

Guys, controllable does not support optifine. I'd be very (pleasantly) surprised if that changed