search

MrCrayfish / Controllable

Adds in the ability to use a controller to play Minecraft Java Edition
https://mrcrayfish.com/mods?id=controllable
GNU General Public License v3.0
271 stars 78 forks source link

Git tags for 1.12.2 versions are pointing to the wrong commits #471

Open Ricket opened 10 months ago

Ricket commented 10 months ago

The three 1.12.2 tags are pointing to 1.16 versions of Controllable for some reason.

For example, the tag 0.11.2-1.12.2 should instead point to commit 11fc95740e1f68f0abb5820507b91746df1fae41.

Also would you be interested in setting up a 1.12.2 branch? I fixed the Little Tiles incompatibility (#175) and can give a PR if you want. Diff can be seen here: https://github.com/Ricket/Controllable/compare/11fc95740e1f68f0abb5820507b91746df1fae41...Ricket:Controllable:steam-deck-e2ee-1.12?expand=1

Note that I haven't done much testing on it yet, just enough to confirm the left and right click actions are functioning. Have not confirmed if LittleTiles is fully-functioning, I haven't used the mod at all yet. I just mainly needed to fix the startup crash.

I was also planning on backporting the <60 FPS fix but it seems like it's not an issue for this version of the mod, low FPSes seem to still react to button presses without dropping any.

mica-alex commented 8 months ago

I can confirm that this fix makes Controllable + LittleTiles work in 1.12! Thank you @Ricket, because I just got a Steam Deck and it was bugging me that I couldn't play my mod pack easily.

I know 1.12 is old, but it would definitely be great to see a PR and official patch released.