search

MrCrayfish / GoblinTraders

Adds goblins that trade speical items with the player!
MIT License
56 stars 39 forks source link

Port to 1.16.3 (Forge 1.16.3-34.0.10) #18

Closed LCLPYT closed 3 years ago

LCLPYT commented 3 years ago

This is a port to 1.16.1 from 1.15.2. I have tested everything from spawning the entities to the coremods. This version works on the client and on the server.

Most changes were just made compatible with the new mappings / method signatures etc. However, since 1.16 some entity attributes must now be registered by the mod, so I had to add a call to GlobalEntityTypeAttributes#put inside the common setup phase. Inside the AbstractGoblinEntity class I also added a new method called prepareAttributes in which the Attributes are registered. The values I used are from the 1.15.2 build of GoblinTraders.

This is only a port, there are no new trade offers for 1.16 items yet.

LCLPYT commented 3 years ago

I also changed the version inside the build.gradle and mods.toml from 1.2.0 to 1.2.1.

LCLPYT commented 3 years ago

Update: 1.16.3 compatible, should probably create a new branch.

MrCrayfish commented 1 year ago

Hey @LCLPYT, I'm currently in the process of relicensing Goblin Traders to MIT and need to get your permission to use your contributions under this new license.

LCLPYT commented 1 year ago

@MrCrayfish No problem, please go ahead 👍