Goblin Traders with Apotheosis are incompatible

MrCrayfish / GoblinTraders

Adds goblins that trade speical items with the player!

MIT License

56 stars 39 forks source link

Goblin Traders with Apotheosis are incompatible #31

Closed celsiusqc closed 3 years ago

celsiusqc commented 3 years ago

You mod does a change to the anvil and so does apotheosis. Apotheosis has a less invasive one. The creator of apotheosis says this is an issue on goblin traders side. Could you please fix https://gist.github.com/celsiusqc/3f8bde8b36cf7c52cf41475e0ba95305

MrCrayfish commented 3 years ago

Literally already been fixed and patch released. I would disagree with invasive, I inject code without replacing. Apotheosis changes getMaxLevel and redirects it to it's own function. I was targeting getMaxLevel and injecting code before it. Game crashed because getMaxLevel doesn't exist since Apotheosis replaced it with it's own method ¯_(ツ)_/¯