search

MrCrayfish / GoblinTraders

Adds goblins that trade speical items with the player!
MIT License
52 stars 37 forks source link

Extending the range of supported entity types to IMerchant #65

Closed LTCatt closed 1 year ago

LTCatt commented 1 year ago

https://github.com/AHilyard/MerchantMarkers/blob/1.16.5/src/main/java/com/anthonyhilyard/merchantmarkers/render/Markers.java

At line 150: if (entity instanceof AbstractVillagerEntity)

If you detect IMerchant instead of AbstractVillagerEntity, this mod can support merchants from more mods. For example, the Goblin Merchant, whose goblin entity does not inherit AbstractVillagerEntity because it does not have Age, but goblin implements IMerchant.

In fact, after I modified this code with mixin, the whole mod worked quite well...

MrCrayfish commented 1 year ago

Well I would suggest that to the author of that mod. Using a Mixin to patch another mod is not a good practice. I am all for adding support, don't get me wrong.

Edit: I believe you posted on the wrong repo based on the wording.

LTCatt commented 1 year ago

oh sorry it's my fault...