MrCrayfish / GoblinTraders

Adds goblins that trade speical items with the player!
MIT License
52 stars 37 forks source link

[1.20.6 Forge] Most Enchantments not working #98

Open Juanakin01 opened 1 month ago

Juanakin01 commented 1 month ago

The following ancient echantments don't work:

Effiency Looting Knockback Sweeping Umbreaking Fortune Respiration Swift Sneak Depht Strider Feather Falling Soul Speed Power

They don't do anything; it's as if no enchantment is applied to the armor/weapon/tool.

The following ancient echantments work perfectly fine:

Sharpness Protection Feather Falling

I have tested this mod completely alone (except for its dependencies, of course).

I downloaded it from the CurseForge launcher.

If you need any extra info just ask.

ElectricKirbo commented 1 week ago

Expanding on this, I tested under the same conditions (I also downloaded from curseforge launcher and only used this mod + dependencies)

Not working - Unbreaking, Looting, Knockback, Fire Aspect, Sweeping Edge, Efficiency, Fortune, Thorns, Respiration, Swift Sneak, Depth Strider, Frost Walker, Soul Speed, Lure, Power, Punch, Loyalty, Riptide, Quick Charge, Piercing

Working - Sharpness, Smite, Bane of Arthropods, Protection, Blast Protection, Fire Protection, Projectile Protection, Feather Falling, Impaling

In the 20 minutes i tested Luck Of The Sea, I couldn't conclude if it is or isn't working. Not too familiar with enchantments in mods, but it seems like only the enchantments that directly increase/decrease damage dealt/taken are working, excluding Power

MrCrayfish commented 5 days ago

I've identified the issue, seems the Mixins that enable the functionality weren't loading on Forge. I'll have a patch out soon