search

MrCrayfish / MrCrayfishFurnitureMod

A Furniture Mod for Minecraft. Download ▶
https://mrcrayfish.com/mods?id=cfm
GNU General Public License v3.0
317 stars 167 forks source link

Language naming conflicts #313

Closed TartaricAcid closed 5 years ago

TartaricAcid commented 6 years ago

Describe the bug MrCrayfishFurnitureMod's I18n don't have namespace, and have some conflicts with other mods

tile.crate.name abyssalcraft: Wooden Crate cfm: Crate harvestcraft: Crate

tile.freezer.name aether_legacy: Freezer cfm: Fridge

tile.bin.name cfm: Bin (rubbish bin) embers: Bin (a large container) In other countries, these are two different words.

tile.mirror.name cfm: Mirror thaumcraft: Magic Mirror

Please complete the following information:

I think the forge doc can help your: https://mcforge.readthedocs.io/en/latest/concepts/internationalization/#usage-with-blocks-and-items

Unlike registry names, translation keys are not namespaced. It is therefore highly recommended to prefix your modid somewhere to the translation key (e.g. examplemod.example_item) to avoid naming conflicts. Otherwise, in the event of a conflict, the localization of one object will override the other.

And I submit the same issues in

MrCrayfish commented 5 years ago

Nothing I can do without breaking every save, only way is to fix it once I can update to 1.13. This mod was created and established before the documentation was even created, so concept standards were never there.

MrCrayfish commented 5 years ago

Edit: Seems it can be fixed just very time consuming.