MrCroxx / RunKV

[WIP] An experimental cloud-native distributed KV engine for OLTP workload.
MIT License
68 stars 7 forks source link

[RFC] feat: concat iterator binary seek #14

Closed MrCroxx closed 2 years ago

MrCroxx commented 2 years ago

A binary seek implementation for ConcatIterator.

NOTICE

After implementing, I found that a BinarySeekableIterator is not needed, because each Iterator needs to implement it in different ways.

MrCroxx commented 2 years ago

Codecov Report

Merging #14 (e57c5fe) into main (0468c58) will increase coverage by 0.23%. The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   93.84%   94.07%   +0.23%     
==========================================
  Files          12       13       +1     
  Lines         569      608      +39     
==========================================
+ Hits          534      572      +38     
- Misses         35       36       +1     
Impacted Files Coverage Δ
storage/src/iterator/concat_iterator.rs 97.81% <93.33%> (-0.63%) :arrow_down:
storage/src/iterator/mod.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0468c58...e57c5fe. Read the comment docs.

MrCroxx commented 2 years ago

Duplicated with #15 , close.