search

MrDHat / generator-node-mocha

Create a Node.js module with yo, including Mocha unit tests.
MIT License
7 stars 7 forks source link

Update _package.json #10

Closed dmfilipenko closed 10 years ago

dmfilipenko commented 10 years ago

Remove nodeunit

MrDHat commented 10 years ago

Leaving nodeunit in package.json was a big blunder! Thanks for fixing. Just update the commit message to a more helpful one and we'll be good to go!

dmfilipenko commented 10 years ago

Change npm module nodeunit to mocha in package.json

MrDHat commented 10 years ago

I meant the commit message. Update the 'commit' message to something like your comment. Update _package.json is not a helpful commit message. (Same goes for the other PR)

dmfilipenko commented 10 years ago

I think, it's impossible or make hard reset to overwrite commit message

MrDHat commented 10 years ago

Do this to update your last commit message: git commit --amend -m '<New Commit message>'

dmfilipenko commented 10 years ago

All done:)

MrDHat commented 10 years ago

I still see 4 different commits. The first commit still says Update _package.json Why not do this:

How does that sound? I think creating a new branch with a new PR might be a better option here instead of wasting energy on correcting this one. I am closing this and the other PR and eagerly waiting for the new one to merge :)