Closed parafoxia closed 2 years ago
No worries! A lot of those changes probably came in the test file cos black basically rewrote that lmao, but yeah, I think it was about an hour's work, so could've been worse haha.
Oh ok. Looked like a lot more but yeah lol. Thanks again!
A lot of the typing changes were pretty simple so that helped. It was really about half an hour on like 2 or 3 things haha, then the CI was a bit weird to sort out.
I'm tempted to open another PR at some point to port the Travis stuff to GitHub Actions, and use pytest instead of nose, but I'll deal with that later 😆
Yeah, I need to go though soon and just start working on updating the whole infrastructure for this project, so if you'd like to help with that your more than welcome to.
Yeah I'll see about it. I've had a lot of practise with infrastructure design with various projects recently so should be able to help with this one 😆
This PR:
All
nosetests
tests have passed on 3.9. Neither nose nor Travis CI support Python 3.10 so functionality on that cannot be properly tested, but in my own limited testing, it does work on 3.10.*While this is breaking, this would not require a bump to v3.0, as those with Python 3.6 or higher will not see any affect in its operation. Those on 3.4 or 3.5 would only be able to download up to v2.1. A bump to v2.2 would suffice.