search

MrDogeBro / sphinx_rtd_dark_mode

Adds a toggleable dark mode to the Read the Docs theme for Sphinx.
sphinx-rtd-dark-mode.vercel.app
MIT License
49 stars 15 forks source link

Highlight sublevels better #11

Open Zethson opened 3 years ago

Zethson commented 3 years ago

Hey,

a request. Currently: image

sublevels (here usage and flags) are not really distinguishable from the header of the section based on colors. The light theme uses a dark grey for the sublevels. Maybe this theme could use dark greys for the sub levels?

Zethson commented 3 years ago

The font is already getting a little bit more grey, right? Hard for me to see.

MrDogeBro commented 3 years ago

@Zethson the font does get a little bit more grey in the sub levels. If it was too much darker however, it could be hard to separate the text from the background.

Zethson commented 3 years ago

What do you think about a better on hover effect? If you mouse over the sublevel gets blue or something.

Zethson commented 3 years ago

@MrDogeBro The dark grey buttons also don't work that well.

Here's an example of what it could look like: https://system-intelligence.readthedocs.io/en/latest/installation.html

I'd suggest to highlight selected levels with a shade of green/blue or something and color the buttons with the same color.

MrDogeBro commented 3 years ago

@Zethson please be descriptive. First of all, the hover effect currently is fine in my opinion. Secondarily, you need to provide examples not only of what you could want something to look like but also what you have a problem with. Just saying dark grey buttons isn't very helpful. My guess would be your talking about the next and previous buttons at the bottom of the page but I couldn't be certain.

If you are talking about those buttons, I personally think they are fine. I also dislike the idea of having super bright colors such as how you stated blue or green as I do not think they look good in the theme, especially it being a dark theme.

Zethson commented 3 years ago

Sorry, was too brief. Yes, I was talking about the buttons like "previous" etc. I personally don't find them easy to read. But perfectly fine if you do. I can still override things for my own docs.

MrDogeBro commented 3 years ago

I mean their is always going to be differences between monitors as well so its hard to know because it looks fine to my eyes on my monitor but it may look different to your eyes on your monitor so who knows. I plan to add more customization in the future so that changes to the themes will be easy with just a setting in the config.