search

MrDys / blacklight

Blacklight Plugin
http://projectblacklight.org/
Other
1 stars 1 forks source link

opensearch problems in Blacklight 3.1.1 #459

Open MrDys opened 12 years ago

MrDys commented 12 years ago

CODEBASE-366: I've just installed Blacklight 3.1.1 as per https://github.com/projectblacklight/blacklight/wiki/Quickstart. I've made only the minimal config changes to point it at an existing Solr index. Testing the opensearch function in FF I received the error message

Firefox could not download the search plugin from: http://dev.bl.toldark.com.au/catalog/opensearch

However, there's no problem in Google Chrome. I've tested this in FF 6.0.2 and FF 7.0.1 under Windows 7 and in FF 3.6.22 in RHEL6. All FF versions have the same issue.

development.log contains

Started GET "/catalog/opensearch" for 192.168.198.160 at Fri Oct 14 13:32:59 +1100 2011 Processing by CatalogController#opensearch as HTML Completed 406 Not Acceptable in 20ms

The Apache log also shows the 406 response:

192.168.198.160 - - [14/Oct/2011:13:32:59 +1100] "GET /catalog/opensearch HTTP/1.1" 406 1 "-" "Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110904 Red Hat/3.6.22-1.el6_1 Firefox/3.6.22"

Is there something I need to do to make this work in FF?

MrDys commented 12 years ago

Original reporter: janna

MrDys commented 12 years ago

jrochkind: Re-opened until test is written, assigned to me. May also incorporate itno render_head_content while I'm at it.

May take me a while to get to, because I still can't manage to set up a working test environment!

MrDys commented 12 years ago

jrochkind: thanks chris.

a) We should add tests for this, when fixing a regression, no? Should I re-open this ticket until that's done?

b) I feel like the opensearch link probably ought to be included in render_head_content instead of being seperate, yes? My idea with render_head_content, is that you should be able to include this ONE line in your local custom BL layout, and get ALL standard BL functionality that belongs in . This way, when you upgrade BL, you get any fixes or enhancements automatically without having to manually inspect and merge them into your local layout -- the way anyone currenty using BL 3.x with a custom layout is going to have to take notice and manually change to get this fix, that's undesirable yes?

MrDys commented 12 years ago

cbeer: a) I wasn't sure how to write (meaningful) tests for this. I'm not sure we're currently testing anything in the layout (though maybe if we do (b), that's fine..)

b) sounds good, but I considered it out of scope for fixing the bug.

MrDys commented 12 years ago

cbeer: Regression from BL 2.x autodiscovery link. Fixed by https://github.com/projectblacklight/blacklight/commit/d2a8c89d3692efc929f472108c8a00e02ed78da6