search

MrDys / blacklight

Blacklight Plugin
http://projectblacklight.org/
Other
1 stars 1 forks source link

Selected Items export tools ought to apply to every item in Selected Items, not just currently displayed page #485

Closed MrDys closed 12 years ago

MrDys commented 12 years ago

CODEBASE-300: Hmm, the way this is implemented makes it hard to change/fix in Blacklight.

The export links in Selected Items actually use actions in CatalogController. And they pass the individual record ID's to the action:

/catalog/email?id%5B%5D=bib_1000000&id%5B%5D=bib_1000002&id%5B%5D=bib_1000003&id%5B%5D=bib_1000004&id%5B%5D=bib_1000005&id%5B%5D=bib_1000006&id%5B%5D=bib_1000007&id%5B%5D=bib_1000008&id%5B%5D=bib_1000009&id%5B%5D=bib_1000010

So if you had 200 things in your Selected Items, there'd be 200 id[]= parameters in the URL. That's not a very nice URL. Eventually you'll run up against the maximum GET URL size most browsers/servers enforce.

So I'm not sure if I'm going to be able to fix this in core, it's going to take more time than I have right now. I'll make a JIRA on it.

I think probably this ought not to re-use the action in catalog controller, but instead there could be an action like /folder/email, /folder/refworks, etc., which took no URL query parameters, but just did it's thing to everything currently in Selected Items.

MrDys commented 12 years ago

Original reporter: jrochkind

MrDys commented 12 years ago

jrochkind: bullk change, pushing past 3.1 in preperation for 3.0.