search

MrDys / blacklight

Blacklight Plugin
http://projectblacklight.org/
Other
1 stars 1 forks source link

Blacklight rspec rake tasks #503

Closed MrDys closed 12 years ago

MrDys commented 12 years ago

CODEBASE-318: As documented, the task to run the Blacklight rspec tests is: rake blacklight:rspec:with_solr

As implemented, the actual task is: rake blacklight:spec:with_solr

I'd vote the former, personally.

MrDys commented 12 years ago

Original reporter: cbeer

MrDys commented 12 years ago

jrochkind: It should be whatever is consistent with the un-adorend rails-rspec provided tasks. We should change conventions set by rspec in the first place as little as possible.

And that is.... "rake spec". So I would personally insist that the BL version should be "blacklight:spec" to be consistent.

On 4/29/2011 3:31 PM, Chris Beer (JIRA) wrote:

Blacklight rspec rake tasks

              Key: CODEBASE-318
              URL: http://jira.projectblacklight.org/jira/browse/CODEBASE-318
          Project: Blacklight Plugin
       Issue Type: Bug
         Reporter: Chris Beer
         Assignee: Jonathan Rochkind
         Priority: Minor
          Fix For: 3.0

As documented, the task to run the Blacklight rspec tests is: rake blacklight:rspec:with_solr

As implemented, the actual task is: rake blacklight:spec:with_solr

I'd vote the former, personally.