search

MrDys / blacklight

Blacklight Plugin
http://projectblacklight.org/
Other
1 stars 1 forks source link

Allow Blacklight to function correctly when no user authentication system is provided #510

Closed MrDys closed 12 years ago

MrDys commented 12 years ago

CODEBASE-325: On Blacklight installation (rails g blacklight) it should be possible to provide an argument that will install Blacklight without requiring a user model or authentication system or installing a default one. This new feature should include

1) user_util partial should not display 'login' link. 2) Actions protected to require auth should not raise unexpectedly on missing #current_user, but if current_user method doesn't even exist should still raise Blacklight::Exceptions::AccessDenied -- the thing that catches the AccessDenied, seeing there being no new_user_session_path to redirect to, should instead display a message "Action requires authentication, which is not implemented in this app" or something like that. 3) Automated tests for this complete "no auth" situation

MrDys commented 12 years ago

Original reporter: danfunk

MrDys commented 12 years ago

cbeer: Maybe?

https://github.com/projectblacklight/blacklight/commit/d3ee1335d2f05d6ee6b82b0e539a920aa3efa259

MrDys commented 12 years ago

cbeer: Hi all,

I took a stab are removing the hard requirement on user authentication in the blacklight app. There's probably elements that can be improved, but at least it will run. I'll try to add documentation (although it should 'just work') and fix up any generator warnings next week

https://github.com/projectblacklight/blacklight/compare/fafd457b2524c14b48096c2daafb380a71cb8d43…9067499b133892ab7dab5a1551b6c4e811cc1a02

Chris

On Oct 21, 2011, at 3:55 PM, Chris Beer (JIRA) wrote:

[ http://jira.projectblacklight.org/jira/browse/CODEBASE-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Beer resolved CODEBASE-325.

  Resolution: Fixed

Fix Version/s: (was: 3.3) 3.2

Maybe?

https://github.com/projectblacklight/blacklight/commit/d3ee1335d2f05d6ee6b82b0e539a920aa3efa259

Allow Blacklight to function correctly when no user authentication system is provided

           Key: CODEBASE-325
           URL: http://jira.projectblacklight.org/jira/browse/CODEBASE-325
       Project: Blacklight Plugin
    Issue Type: New Feature

Affects Versions: 3.0 Reporter: Dan Funk Assignee: Chris Beer Fix For: 3.2

On Blacklight installation (rails g blacklight) it should be possible to provide an argument that will install Blacklight without requiring a user model or authentication system or installing a default one. This new feature should include 1) user_util partial should not display 'login' link. 2) Actions protected to require auth should not raise unexpectedly on missing #current_user, but if current_user method doesn't even exist should still raise Blacklight::Exceptions::AccessDenied -- the thing that catches the AccessDenied, seeing there being no new_user_session_path to redirect to, should instead display a message "Action requires authentication, which is not implemented in this app" or something like that. 3) Automated tests for this complete "no auth" situation

This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators: http://jira.projectblacklight.org/jira/secure/Administrators.jspa

For more information on JIRA, see: http://www.atlassian.com/software/jira

MrDys commented 12 years ago

cbeer: Batch move to 3.0.1