MrDys / blacklight

Blacklight Plugin
http://projectblacklight.org/
Other
1 stars 1 forks source link

saving Selected Items (Folder) to Bookmarks (SavedRecords), more than 10 #523

Open MrDys opened 12 years ago

MrDys commented 12 years ago

CODEBASE-341: If you put more items in Selected Items then the current pagination. Say 15, when it only shows 10 at a time.

And then you choose "Add to Bookmarks".

It only adds the first 10. In BL2 it added all of them. (I think I recall fixing a bug where it didn't before, it was a doozy, somehow regression in BL3?).

Woudl be good for someone to confirm/reproduce this, but that's what it's looking like to me.

MrDys commented 12 years ago

Original reporter: jrochkind

MrDys commented 12 years ago

cbeer: Looks like this is probably related to CODEBASE-300

Pagination for folders is pretty magical -- get_solr_response_for_field_values calls solr_search_params with empty parameters (https://github.com/projectblacklight/blacklight/blob/master/lib/blacklight/solr_helper.rb#L121), which loads params as the default argument.