search

MrDys / blacklight

Blacklight Plugin
http://projectblacklight.org/
Other
1 stars 1 forks source link

fix rake solr:marc:index task and generator to use distro SolrMarc.jar #546

Closed MrDys closed 12 years ago

MrDys commented 12 years ago

CODEBASE-375: "rake solr:marc:index" was originally intended to use a SolrMarc.jar from distro code, only using a local SolrMarc.jar if the local app had one.

However, with BL 3.0, the generator ALWAYS copies a local SolrMarc.jar, which it wasn't originally intended to do. BL 3.x "rake solr:marc:index" may or may not actually work with only a distro SolrMarc.jar, it may actually be hard-coded to expect a local SolrMarc.jar.

This isn't what was originally intended, and the downside is when you upgrade BL, even if you haven't intentionally installed a custom version of SolrMarc.jar, the BL install process did install a local one, and your app is 'frozen' to whatever version of SolrMarc.jar was copied to local app when you originally installed BL -- you don't get the new version of SolrMarc.jar that comes wtih new the version of BL.

This should be fixed to work as originally intended.

MrDys commented 12 years ago

Original reporter: jrochkind

MrDys commented 12 years ago

jrochkind: Fixed.

  1. Blacklight generator does not generate SolrMarc.jar into local app anymore.
  2. Blacklight's distro SolrMarc.jar is at $blacklight/lib/SolrMarc.jar, and will be used by rake solr:marc:index if no local app SolrMarc.jar.
  3. If local app puts it's own compile of SolrMarc.jar at Rails.root/lib/SolrMarc.jar, rake solr:marc:index will use that instead.

Suggested release notes:

"Previous versions of Blacklight copied a SolrMarc.jar into your local app's lib/SolrMarc.jar when installing Blacklight. Unless you have intentionally installed a local compile of SolrMarc.jar there, you should remove that file, so your app will use the latest version of SolrMarc shipped with Blacklight."