search

MrFantiVideo / MineGate

Add lots of blocks and new variations. (Minecraft)
https://minegate.fr
4 stars 3 forks source link

Suggestion for stick variants #1

Closed JayCeeCreates closed 3 years ago

JayCeeCreates commented 3 years ago

I would like to suggest that the stick variants (spruce, birch, etc.) be added to common tags for better compatibility with several mods that add tools. Your response would be greatly appreciated-

MrFantiVideo commented 3 years ago

Hello,

Can you clarify for me what you mean by « common tags » ? It seems to me that I have already modified the « sticks.json » file in order to make all sticks compatible with all crafts.

JayCeeCreates commented 3 years ago

Now put that sticks.json to resources\data\c\tags\items

MrFantiVideo commented 3 years ago

I change this in the new version. (MoreBlocks 1.1.3) Can you confirm for me that this is what you want?

JayCeeCreates commented 3 years ago

Created a pull request which does what I'm talking about-

MrFantiVideo commented 3 years ago

I would just like to understand why you want to use « c » and what does that change? Do other mods also use this way? or the Fabric documentation says something about it that I haven't seen?

Thanks in advance, otherwise I could put all of this in place after my exams.

JayCeeCreates commented 3 years ago

One of the sole reasons I can give is that someone using our mods (EarlyGame and MineGate) found out that using your modded sticks to craft my modded tools doesn't work. The same happened with All The Blocks You Want. This is to ensure compatibility with mods that add modded tools so that the recipes use the common stick tag.

It's like having a modded copper ingot be added to common copper ingot tag so that mods with modded copper tools can use c:copper_ingots.

I hope you understand-

JayCeeCreates commented 3 years ago

https://fabricmc.net/wiki/tutorial:tags#creating_new_common_tags This can help in understanding common tags

MrFantiVideo commented 3 years ago

Thanks for the link to the documentation! I understand better why the use « c », this modification will be present in the next version of the mod.

(Sorry for the time to understand, it's not always easy to translate correctly from English to French...)

MrFantiVideo commented 3 years ago

Modification present in version 1.1.5 of mod. Thank you for your contribution.