search

MrFantiVideo / MineGate

Add lots of blocks and new variations. (Minecraft)
https://minegate.fr
4 stars 3 forks source link

Bone Meal behavior and crash #21

Closed cryxli closed 2 years ago

cryxli commented 2 years ago

Observation

When Bone Meal-ing vanilla Grass Blocks not only flowers are generated, but trees, too. Especially Azalea appear all the time. But I already have seen Dark Oak and Spruce.

Basically, with MineGate you can turn your flower farm into a tree farm. But its a little bit of a headache. :-D

I would expect that Bone Meal only produces flowers, tall grass, etc. but not trees.

Setup

Guess Work

It most likely relates to issue #10. The SlabGrassBlock mixin seems to trigger with vanilla Grass Blocks, too. And then delegates flower growing to chunk managers. They use the world gen logic to generate everything, not just flowers.

This guess is supported by the crash-2022-02-18_11.05.18-server.txt I see occasionally. I cannot reproduce it reliably. But perhaps it helps. - It comes from a flower farm, that only uses vanilla Grass Blocks that are moved back and forth with pistons. The classic.

Suggestion

Disable the SlabGrassBlock.growAll() with a config property until the behavior is understood and eventually fixed.

I really like the variety MineGate adds to Fabric. Great work!

Laifsyn commented 2 years ago

Hey, a follow up. Apparently it also grows hay bales ^^; image

MrFantiVideo commented 2 years ago

Fixed in the new version. (MoreBlocks 1.2.0) I would like to have your confirmation, to be sure that I have found the cause of the problem.

the-ecips commented 2 years ago

Hello! We were having the same issue with the bonemeal and I'm happy to see you fixed it :) We're playing on a server on v1.18.1, is there a chance to somehow get the fix for the older version, too?

I'm very sorry if this is a stupid question to ask, I don't know anything about coding :/ All I know is that we can't update since most of the mods we use are still on 1.18.1 (which is a bummer).

Thank you for your time :)

MrFantiVideo commented 2 years ago

Hello! We were having the same issue with the bonemeal and I'm happy to see you fixed it :) We're playing on a server on v1.18.1, is there a chance to somehow get the fix for the older version, too?

I'm very sorry if this is a stupid question to ask, I don't know anything about coding :/ All I know is that we can't update since most of the mods we use are still on 1.18.1 (which is a bummer).

Thank you for your time :)

I don't think to update the old versions, I will eventually see to do it as soon as I have fixed some bugs of the new version.

the-ecips commented 2 years ago

Understandable. Thank you for your reply! :)