MrFarland / DM-Operations-Center

The DM Operations Center is a collection of rules and tools for 5th edition Dungeons & Dragons dungeon masters that use the advanced Virtual Tabletop application Encounter+
https://donfarland.com
Other
38 stars 10 forks source link

Proof of Concept for generators (through a NPC generator) #69

Closed Felixmil closed 2 years ago

Felixmil commented 2 years ago

Finally ! I'm finally able to submit this PR for your to test and review the system I designed (outrageously reusing Doug Rau's material.

What are all these files ?

JS scripts

HTML file

How does it work ?

Limitations

Final words

All these may seem clunky sketchy: this is normal, I never wrote a line of JS before working on this. So this PR is not much but I hope it will spark some ideas and maybe lay the fondations of the future generators for the awesome work you are doing with this project.

Don't hesitate to get in touch with me if you want to discuss it further.

Cheers,

Felix

MrFarland commented 2 years ago

I'll try and take a look tomorrow. Can't wait.

TheCrazySpy commented 2 years ago

I'm not too familiar with javascript, does spacing matter? There's a few places where the comma separated lists of strings have spaces and others that don't. I'd imagine it doesn't matter.

MrFarland commented 2 years ago

Looks good. I didn't get a chance to really dive into the code, but will try and do so this week. Thanks for the hard work.

MrFarland commented 2 years ago

It depends. Pretty much only inside quotes for strings, but I wouldn't worry about it yet. I suspect a lot will change over the next couple of weeks.

Felixmil commented 2 years ago

I'm not too familiar with javascript, does spacing matter? There's a few places where the comma separated lists of strings have spaces and others that don't. I'd imagine it doesn't matter.

It does not matter for it to work, but I recognize it is lack of consistency regarding formatting. As MrFarland said just above, those will inevitably change if reused anyway.

Have fun with it !

TheCrazySpy commented 2 years ago

Great!