Open jakechai opened 1 week ago
i thought I had messed it up somehow so i reinstalled comfyui with the torch it says to on the front page and now its forcing specific versions of everything. are we not using torch-2.3.0+cu121-cp311-cp311-win_amd64.whl torchvision-0.18.0+cu121-cp311-cp311-win_amd64.whl torchaudio-2.3.0+cu121-cp311-cp311-win_amd64.whl anymore? what do we do here?
same here, installing 3D pack come with torch==2.4.0 - making a failed install - or I am missing something ?
same here
i think ive got it working, dont know why but build_config.yaml specifies versions of things, change the version of torch to 2.3.0, torchvision to 0.18.0, and xformers to 0.0.26 post1
i think ive got it working, dont know why but build_config.yaml specifies versions of things, change the version of torch to 2.3.0, torchvision to 0.18.0, and xformers to 0.0.26 post1
well actually not sure if that fixed it, but i followed your suggestion, got another error, that my c++ redis couldn't be found and after fixing that it seems to work... Thank you :)
i think ive got it working, dont know why but build_config.yaml specifies versions of things, change the version of torch to 2.3.0, torchvision to 0.18.0, and xformers to 0.0.26 post1
It works for me! thanks!
I'll rebuild all the wheels to support torch 2.4.0 and torchvision 0.19 before end of this week 👍
Hi, I just rebuilt all the wheels for Windows, python 3.10, 3.11, 3.12, cuda 11.8. 12.1, pytorch 2.4.0
, please let me know if there are any other problems 👍
Hi, I just rebuilt all the wheels for
Windows, python 3.10, 3.11, 3.12, cuda 11.8. 12.1, pytorch 2.4.0
, please let me know if there are any other problems 👍
Thanks for the wheels! But the errors are the same as before, so I have to roll it back. Can the new features be run on torch==2.3.0, torchvision==0.18, xformers==0.0.26.post1?
Installation is annoying enough, and then...
@jakechai Yeah, I just realized a problem yesterday, if you have installed the package for torch 2.3.0 before then you have to uninstall those pre-built wheels before you can install the new packages, otherwise pip install will skip it, I'll update the install.py to auto uninstall the old packages
Ok, I just updated the install.py to make it run pip install --no-deps --force-reinstall <pre-built wheels>
, it should be able to overwrite those old wheels in your ComfyUI python environment now
I spent half a day deploying the torch2.3.0 environment. When I thought it was about to succeed, 3d-pack helped me update the environment to 2.4.0. Obviously, this was a disaster!
@Firetheft Yeah, sorry for the trouble, a few days ago when I changed the config file, I didn't realise simply update from torch 2.3.0 to 2.4.0 would need rebuilt all the dependencies. But it should work now by pulling the main, pip -r requirement.txt and running install.py let me know here if there are other things I can help 👍
@Firetheft Yeah, sorry for the trouble, a few days ago when I changed the config file, I didn't realise simply update from torch 2.3.0 to 2.4.0 would need rebuilt all the dependencies. But it should work now by pulling the main, pip -r requirement.txt and running install.py let me know here if there are other things I can help 👍
I just reverted my environment to 2.3.0, and then I stupidly installed 3d-pack again in Manager...
Ok, I just updated the install.py to make it run
pip install --no-deps --force-reinstall <pre-built wheels>
, it should be able to overwrite those old wheels in your ComfyUI python environment now
I tried, errors are still there. But it works after the fixes blow:
torchaudio: pip install torchaudio-2.4.0+cu121-cp311-cp311-win_amd64.whl
by myself.
torch_scatter: pip install --force-reinstall torch-scatter==2.1.2 -f https://data.pyg.org/whl/torch-2.4.0+cu121.html
to upgrade to torch-scatter-2.1.2+pt24cu121
warnings
E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\xformers\ops\fmha\flash.py:211: FutureWarning: torch.library.impl_abstract
was renamed to torch.library.register_fake
. Please use that instead; we will remove torch.library.impl_abstract
in a future version of PyTorch.
@torch.library.impl_abstract("xformers_flash::flash_fwd")
E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\xformers\ops\fmha\flash.py:344: FutureWarning: torch.library.impl_abstract
was renamed to torch.library.register_fake
. Please use that instead; we will remove torch.library.impl_abstract
in a future version of PyTorch.
@torch.library.impl_abstract("xformers_flash::flash_bwd")
E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning: torch.cuda.amp.custom_fwd(args...)
is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda')
instead.
@torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\kiui\nn__init__.py:31: FutureWarning: torch.cuda.amp.custom_fwd(args...)
is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda')
instead.
@torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\kiui\nn__init__.py:37: FutureWarning: torch.cuda.amp.custom_bwd(args...)
is deprecated. Please use torch.amp.custom_bwd(args..., device_type='cuda')
instead.
@torch.cuda.amp.custom_bwd
E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\Gen_3D_Modules\TriplaneGaussian\utils\ops.py:38: FutureWarning: torch.cuda.amp.custom_fwd(args...)
is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda')
instead.
@custom_fwd(cast_inputs=torch.float32)
E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\Gen_3D_Modules\TriplaneGaussian\utils\ops.py:44: FutureWarning: torch.cuda.amp.custom_bwd(args...)
is deprecated. Please use torch.amp.custom_bwd(args..., device_type='cuda')
instead.
@custom_bwd
Warn!: E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\Gen_3D_Modules\craftsman\utils\checkpoint.py:39: FutureWarning: torch.cuda.amp.custom_fwd(args...)
is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda')
instead.
@torch.cuda.amp.custom_fwd
Warn!: E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\Gen_3D_Modules\craftsman\utils\checkpoint.py:50: FutureWarning: torch.cuda.amp.custom_bwd(args...)
is deprecated. Please use torch.amp.custom_bwd(args..., device_type='cuda')
instead.
@torch.cuda.amp.custom_bwd
Ok, I just updated the install.py to make it run
pip install --no-deps --force-reinstall <pre-built wheels>
, it should be able to overwrite those old wheels in your ComfyUI python environment nowI tried, errors are still there. But it works after the fixes blow: torchaudio:
pip install torchaudio-2.4.0+cu121-cp311-cp311-win_amd64.whl
by myself. torch_scatter:pip install --force-reinstall torch-scatter==2.1.2 -f https://data.pyg.org/whl/torch-2.4.0+cu121.html
to upgrade totorch-scatter-2.1.2+pt24cu121
warnings E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\xformers\ops\fmha\flash.py:211: FutureWarning:
torch.library.impl_abstract
was renamed totorch.library.register_fake
. Please use that instead; we will removetorch.library.impl_abstract
in a future version of PyTorch. @torch.library.impl_abstract("xformers_flash::flash_fwd") E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\xformers\ops\fmha\flash.py:344: FutureWarning:torch.library.impl_abstract
was renamed totorch.library.register_fake
. Please use that instead; we will removetorch.library.impl_abstract
in a future version of PyTorch. @torch.library.impl_abstract("xformers_flash::flash_bwd")E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning:
torch.cuda.amp.custom_fwd(args...)
is deprecated. Please usetorch.amp.custom_fwd(args..., device_type='cuda')
instead. @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32) E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\kiui\nninit.py:31: FutureWarning:torch.cuda.amp.custom_fwd(args...)
is deprecated. Please usetorch.amp.custom_fwd(args..., device_type='cuda')
instead. @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32) E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\kiui\nninit.py:37: FutureWarning:torch.cuda.amp.custom_bwd(args...)
is deprecated. Please usetorch.amp.custom_bwd(args..., device_type='cuda')
instead. @torch.cuda.amp.custom_bwd E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\Gen_3D_Modules\TriplaneGaussian\utils\ops.py:38: FutureWarning:torch.cuda.amp.custom_fwd(args...)
is deprecated. Please usetorch.amp.custom_fwd(args..., device_type='cuda')
instead. @custom_fwd(cast_inputs=torch.float32) E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\Gen_3D_Modules\TriplaneGaussian\utils\ops.py:44: FutureWarning:torch.cuda.amp.custom_bwd(args...)
is deprecated. Please usetorch.amp.custom_bwd(args..., device_type='cuda')
instead. @custom_bwd Warn!: E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\Gen_3D_Modules\craftsman\utils\checkpoint.py:39: FutureWarning:torch.cuda.amp.custom_fwd(args...)
is deprecated. Please usetorch.amp.custom_fwd(args..., device_type='cuda')
instead. @torch.cuda.amp.custom_fwd Warn!: E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\Gen_3D_Modules\craftsman\utils\checkpoint.py:50: FutureWarning:torch.cuda.amp.custom_bwd(args...)
is deprecated. Please usetorch.amp.custom_bwd(args..., device_type='cuda')
instead. @torch.cuda.amp.custom_bwd
I did almost the same, but I still have a 304 cuda error, I can successfully install but not able to open it. After future warning I have a 304 error
Check the NVIDIA settings and the display driver.
Errors occur after the update and ComfyUI fails to import the 3D Pack. Rolling back to the previous stable version of ComfyUI python_embeded to solve. But I don't know if it will affect the new features.
pytorch version: 2.4.0+cu121 E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\xformers\ops\fmha\flash.py:211: FutureWarning:
torch.library.impl_abstract
was renamed totorch.library.register_fake
. Please use that instead; we will removetorch.library.impl_abstract
in a future version of PyTorch. @torch.library.impl_abstract("xformers_flash::flash_fwd") E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\xformers\ops\fmha\flash.py:344: FutureWarning:torch.library.impl_abstract
was renamed totorch.library.register_fake
. Please use that instead; we will removetorch.library.impl_abstract
in a future version of PyTorch. @torch.library.impl_abstract("xformers_flash::flash_bwd") xformers version: 0.0.27.post2 Set vram state to: NORMAL_VRAM Device: cuda:0 NVIDIA GeForce RTX 2070 SUPER : cudaMallocAsync Using xformers cross attentionE:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning:", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\comfy_extras\nodes_audio.py", line 1, in
import torchaudio
File "E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\torchaudio__init.py", line 2, in
from . import _extension # noqa # usort: skip
^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\torchaudio_extension\ init.py", line 38, in
_load_lib("libtorchaudio")
File "E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\torchaudio_extension\utils.py", line 60, in _load_lib
torch.ops.load_library(path)
File "E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\torch_ops.py", line 1295, in load_library
ctypes.CDLL(path)
File "ctypes\ init.py", line 376, in init__
OSError: [WinError 127] 找不到指定的程序。
torch.cuda.amp.custom_fwd(args...)
is deprecated. Please usetorch.amp.custom_fwd(args..., device_type='cuda')
instead. @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32) Traceback (most recent call last): File "E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\nodes.py", line 1994, in load_custom_node module_spec.loader.exec_module(module) File "Cannot import E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\comfy_extras\nodes_audio.py module for custom nodes: [WinError 127] 找不到指定的程序。 Traceback (most recent call last): File "E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\nodes.py", line 1994, in load_custom_node module_spec.loader.exec_module(module) File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack__init.py", line 53, in
module = importlib.import_module(f".{nodes_filename}", package= name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "importlib__init.py", line 126, in import_module
File "", line 1204, in _gcd_import
File "", line 1176, in _find_and_load
File "", line 1147, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\nodes.py", line 50, in
from FlexiCubes.flexicubes_trainer import FlexiCubesTrainer
File "E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\MVs_Algorithms\FlexiCubes\flexicubes_trainer.py", line 13, in
from .loss import sdf_reg_loss
File "E:\Program Files\ComfyUI_windows_portable_3D\ComfyUI\custom_nodes\ComfyUI-3D-Pack\MVs_Algorithms\FlexiCubes\loss.py", line 9, in
import torch_scatter
File "E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\torch_scatter\ init__.py", line 16, in
torch.ops.load_library(spec.origin)
File "E:\Program Files\ComfyUI_windows_portable_3D\python_embeded\Lib\site-packages\torch_ops.py", line 1295, in load_library
ctypes.CDLL(path)
File "ctypes\ init.py", line 376, in init__
OSError: [WinError 127] 找不到指定的程序。