Breaks a ROCm venv

[ricperry]

Beware, installing this will break a ROCm pytorch environment. After you install this you'll need to reinstall the ROCm torch:

pip uninstall torch torchvision && pip install torch torchvision --index-url https://download.pytorch.org/whl/rocm5.7

Once you do this, the node will fail to load, but at least you can still use ComfyUI, and hopefully MrForExample can fix the node.

[wikidude]

They will never understand not to play with people's environments. At least this one only has torch and xformers. I've seen others enforcing xformers in their code with 'xformers=true' and the only way to turn it off is to find the 3 lines of code in 500 files that use it and turn it off. "The current goal of this project is to achieve desired pose2video result with 1+FPS on GPUs that are equal to or better than RTX 3080!" Well the 7900XTX is better than RTX3080. Why break it? Torch and Xformers should be the job of the user and the UI to install. They should never be required by custom nodes as users already have them, otherwise they wouldn't be able to use Comfy in the first place.

[MrForExample]

@ricperry Sorry for the trouble, I was not aware of this issue, I'll take a look at this when I got some free time, if you know the better way to handle the installation without the potential env conflict problems feel free to let me know, cheers 👍

@wikidude xformers will only be enabled if user installed it, and I didn't force the cuda torch and torchvision installation, currently I'm not really sure which package caused the issue for ROCm torch, if you know then please tell me 👍

[chiragkrishna]

Your requirements file has xformers. Which forces reinstall of nvidia torch and torchvision. Can you remove it from requirements.

to revert the changes and get rocm support back

pip uninstall torch torchvision torchaudio xformers

pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/rocm5.7