MrGenie151 / Ender-Dragon-Fight-Remastered

An up in the difficulty of the final boss fight of Minecraft.
GNU General Public License v3.0
3 stars 3 forks source link

"#Giant Stuff" hurt server that utilize `minecraft:giant` mob (like giant spawn naturally) #10

Closed cupang-afk closed 1 year ago

cupang-afk commented 1 year ago

idk what you thinking but

DUDE, THIS HELL IS HURTING MY SERVER TPS

# Giant Stuff
execute as @e[type=minecraft:giant,tag=!init] at @s run summon giant ~ ~ ~ {Tags:["init","giant"],Passengers:[{id:"minecraft:zombie",NoAI:0b,Tags:["giant_brain","giant"],ActiveEffects:[{Id:14,Amplifier:1b,Duration:999999999999,ShowParticles:0b}]}],ArmorItems:[{},{},{},{id:"minecraft:player_head",Count:1b,tag:{SkullOwner:"eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvYTJhZjYyMzE4OTBiNjQ4MWFkN2Y5NWQxNTBhYzRkNDM3NDA1ODFlZjhiYTA3OTQ0ODc4M2VmYmVlOGVlZjljMCJ9fX0="}}]}
execute as @e[type=minecraft:giant,tag=!init] at @s run tp @s 0 0 0
execute as @e[tag=giant] unless entity @s[tag=!init] run function endfight:giant

like imagine we have 4 minecraft:giant spawn naturally

EVERY TICK THEY SPAWN ANOTHER GIANT IN THE 0 0 0 UNTIL IT WAS LIKE 200++ OF THEM

AND THE ENDER DRAGON FIGHT DOESNT EVEN HAVE GIANT FIGHT

DUDE WHY

sorry bout the caps, but please fix this if possible

cupang-afk commented 1 year ago

ps: all the caps was from my effort finding the culprit behind this tps drop, that is frustating cuz i had to use spark profiler instead of aikar timings (purpur server stuff, and i hate that)

cupang-afk commented 1 year ago

ps again: if this inappropriate please just delete this

cupang-afk commented 1 year ago

update: after discussion with some of my player about removing the datapack from the server, they agreed, and i remove the datapack its true, the tps is no longer dropping and minecraft:giant is spawned properly (no longer spawning new giant at 0 0 0)

so sad that my player liked this datapack but i had to remove it cuz the performance

i use MythicMobs to control the miencraft:giant random spawn, and yes it override the giant so it can have its own brain/ai and it also (probably) the plugin which remove Tags:["init","giant"] from the giant, then your datapack keep summoning new giant at 0 0 0 because @e[type=minecraft:giant,tag=!init]

MrGenie151 commented 1 year ago

idk what you thinking but

DUDE, THIS HELL IS HURTING MY SERVER TPS

# Giant Stuff
execute as @e[type=minecraft:giant,tag=!init] at @s run summon giant ~ ~ ~ {Tags:["init","giant"],Passengers:[{id:"minecraft:zombie",NoAI:0b,Tags:["giant_brain","giant"],ActiveEffects:[{Id:14,Amplifier:1b,Duration:999999999999,ShowParticles:0b}]}],ArmorItems:[{},{},{},{id:"minecraft:player_head",Count:1b,tag:{SkullOwner:"eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvYTJhZjYyMzE4OTBiNjQ4MWFkN2Y5NWQxNTBhYzRkNDM3NDA1ODFlZjhiYTA3OTQ0ODc4M2VmYmVlOGVlZjljMCJ9fX0="}}]}
execute as @e[type=minecraft:giant,tag=!init] at @s run tp @s 0 0 0
execute as @e[tag=giant] unless entity @s[tag=!init] run function endfight:giant

like imagine we have 4 minecraft:giant spawn naturally

EVERY TICK THEY SPAWN ANOTHER GIANT IN THE 0 0 0 UNTIL IT WAS LIKE 200++ OF THEM

AND THE ENDER DRAGON FIGHT DOESNT EVEN HAVE GIANT FIGHT

DUDE WHY

sorry bout the caps, but please fix this if possible

Oops.

This was from an early stage of development when i wanted to make the dragon to spawn giants guess i forgot to remove it

I will mark it as urgent and remove the unused code from the datapack. Seriously sorry about that!

MrGenie151 commented 1 year ago

It should be fixed now! Sorry for lagging the server im really sorry about that

MrGenie151 commented 1 year ago

Closed