search

MrGlockenspiel / activate-linux

The "Activate Windows" watermark ported to Linux
GNU General Public License v3.0
4.4k stars 92 forks source link

Added japanese support #104

Closed onion108 closed 2 years ago

ReperakDev commented 2 years ago

This seems to mess with the order of the words (symbols?) in the Chinese translations. Another note, I don't know the Japanese language, but is the additional code necessary?

BeautyyuYanli commented 2 years ago

This seems to mess with the order of the words (symbols?) in the Chinese translations. Another note, I don't know the Japanese language, but is the additional code necessary?

No problem with the order. The order of Japanese phrases is opposite of Chinese and English, so I suggest splitting title

ReperakDev commented 2 years ago

This seems to mess with the order of the words (symbols?) in the Chinese translations. Another note, I don't know the Japanese language, but is the additional code necessary?

No problem with the order. The order of Japanese phrases is opposite of Chinese and English, so I suggest splitting title

Okay, but that's not what I'm saying. When I tested, this PR changed the order of the Chinese translations, when its only meant to change Japanese

BeautyyuYanli commented 2 years ago

It looks like no problem with the order on my device

image

onion108 commented 2 years ago

This seems to mess with the order of the words (symbols?) in the Chinese translations. Another note, I don't know the Japanese language, but is the additional code necessary?

No problem with the order. The order of Japanese phrases is opposite of Chinese and English, so I suggest splitting title

Okay, but that's not what I'm saying. When I tested, this PR changed the order of the Chinese translations, when its only meant to change Japanese

it seems impossible. Could you please provide at least one screenshot and tell me how did you install the fork? Thanks a lot.