MrGlockenspiel / activate-linux

The "Activate Windows" watermark ported to Linux
GNU General Public License v3.0
4.25k stars 91 forks source link

X11 and logging related patches #134

Closed ahmubashshir closed 1 year ago

ahmubashshir commented 2 years ago

Closes #133 Closes #129

AHOHNMYC commented 2 years ago

Ah, the best sort of commits where most of files are changed because of no valuable reason (too smart IDE with custom code style) :D (I like what you have fixed BTW)

ahmubashshir commented 2 years ago

Ah, the best sort of commits where most of files are changed because of no valuable reason (too smart IDE with custom code style) :D (I like what you have fixed BTW)

You mean d9054dc? I did that because each file was different, tabs somewhere, space elsewhere, and my pre-commit hooks didn't like it 🙃

edit: the offending hook

So, ran astyle on all files before doing anything valuable so that I can commit without annoyance 🚀

P.S. I don't use any too Smart IDE(tbh not any IDE, they're bloat for most of the task) 😎 did everything with nano/sed/ack and tmux 🙃

image

ahmubashshir commented 2 years ago

P.S. I'll implement #132 and #135 in my next PR.

And guys from #58, try this and confirm if this PR solves your issue.

MrGlockenspiel commented 2 years ago

wait are these the same patches you emailed me? because i already merged those

ahmubashshir commented 2 years ago

wait are these the same patches you emailed me? because i already merged those

Please drop those and merge this if possible 🥺

I accidentally ran git send-email before finishing patch v2 formatting 😨

# run these commands to rebase to this pr
git stash
git reset --hard 4c848f4
git fetch origin refs/pull/134/head:pr-134
git rebase pr-134
git stash pop
MrGlockenspiel commented 1 year ago

sorry im late, have been busy

ill get to that asap

MrGlockenspiel commented 1 year ago

wow i didnt break anything