search

MrGreensWorkshop / MrGreen-JekyllTheme

Mr. Green is a multilingual theme generated with Jekyll and fully compatible with GitHub Pages.
https://jekyll-theme-mrgreen-demo.mrgreensworkshop.com
MIT License
154 stars 294 forks source link

The type of sliding box animation could be changed from its init function #136

Closed MrGreensWorkshop closed 1 year ago

MrGreensWorkshop commented 1 year ago

Is this enhancement or feature is related to a problem?

SlidingMsgBox were used for language_translation_offer_box feature and cookie consent box. However, the slide type is set as shown below. (It looks like it's only used for language_translation_offer_box)

https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/765026edf1d64d5113756ecd5dce0dc6707ef184/_includes/default/sliding-msg-box.html#L7-L11

This could be easily misunderstood, as I did before. #135  

Describe the solution you'd like

It may be possible to correct the misconfiguration by setting the slide type of the sliding box in its init function.

With this, we can individually set the slide type for both the language offer box and the cookie consent setting box at _data/conf/main.yml.

Describe alternatives you've considered

none

Additional context

none

MrGreensWorkshop commented 1 year ago

done with PR #137.