search

MrGreensWorkshop / MrGreen-JekyllTheme

Mr. Green is a multilingual theme generated with Jekyll and fully compatible with GitHub Pages.
https://jekyll-theme-mrgreen-demo.mrgreensworkshop.com
MIT License
153 stars 295 forks source link

Giscus support #162

Closed SageofPHY6Paths closed 1 year ago

SageofPHY6Paths commented 1 year ago

Is this enhancement or feature is related to a problem?

Thanks for making this awesome theme and making it open source. All the themes I could find were very minimalist.

https://giscus.app/ or https://github.com/giscus/giscus is a recent alternative to discus. It is free, open source, privacy focused and uses GitHub discussions.

Add giscus support to this theme.

Describe the solution you'd like

I can add it very easily using the steps at https://giscus.app/ but I myself can't do fine changes like configure such that when the dark toggle is clicked the giscus comments also change the theme. But I guess you will be able to do this. So official support is better. by default you can keep disqus but give the option to change to giscus in the config file or somewhere.

Thanks.

Describe alternatives you've considered

No response

Additional context

No response

SageofPHY6Paths commented 1 year ago

There is a small problem here though, giscus as of now doesn't have the ability to show the number of comments outside the post page. https://github.com/giscus/giscus/issues/145

But that feature is not that important in my opinion. You can set up if else functions such that in the config file if giscus is selected then the number of comments will be automatically removed.