MrGreensWorkshop / MrGreen-JekyllTheme

Mr. Green is a multilingual theme generated with Jekyll and fully compatible with GitHub Pages.
https://jekyll-theme-mrgreen-demo.mrgreensworkshop.com
MIT License
153 stars 296 forks source link

Korean language support #177

Closed MrGreensWorkshop closed 1 month ago

MrGreensWorkshop commented 1 year ago

Is this enhancement or feature is related to a problem?

Public message for anyone who speaks Korean.

I intend to add Korean language support. I've already translated everything, but I need volunteers to double-check the translations. Could you please take a look and check if these translations are okay?

line, 4 https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/ko/_posts/2023-02-19-mr-green-jekyll-theme.markdown?plain=1#L4

line 5,11,45 https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/_data/owner/ko.yml

line, 7,8,15,18,21,28,29,176,177,189,210,218,226 https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/_data/content/projects/ko.yml

line, 44,45,52,55,65,71,73,75,77,79,81,83,85,87,93 https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/ko/tabs/links.md?plain=1

Almost all lines https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/_data/lang/ko.yml

Almost all lines https://github.com/MrGreensWorkshop/MrGreen-JekyllTheme/blob/feature_korean_language_support/README-ko.md

If you think there is a mistake in the translation, please let me know by commenting on this issue, or you can submit a PR targeted to the this branch feature_korean_language_support.

Thanks in advance.

Describe the solution you'd like

Adding Korean Language

Describe alternatives you've considered

No response

Additional context

No response

MrGreensWorkshop commented 1 year ago

@fandangos Hi, I'm going to add Korean language support, and I need your advice because I need to add language lists to all Readme files. Is it okay to say Coreano or Coreana for Korean, as shown below? (for the Portuguese readme file)

Inglês (padrão), Japonês, Português do Brasil, Coreano

Thanks in advance.

fandangos commented 1 year ago

@fandangos Hi, I'm going to add Korean language support, and I need your advice because I need to add language lists to all Readme files. Is it okay to say Coreano or Coreana for Korean, as shown below?

readme file Inglês (padrão), Japonês, Português do Brasil, Coreano

Thanks in advance.

The correct is Coreano as you are referencing the language, in Portuguese it's referencing to "idioma" and while it ends in a which would be feminine we refer to it using masculine article "O". Ex: O português e O coreanO because it's O idioma Coreano.

Sorry for the late reply and hope the explanation is clear enough to help here.

MrGreensWorkshop commented 1 year ago

The correct is Coreano as you are referencing the language, in Portuguese it's referencing to "idioma" and while it ends in a which would be feminine we refer to it using masculine article "O". Ex: O português e O coreanO because it's O idioma Coreano.

Sorry for the late reply and hope the explanation is clear enough to help here.

@fandangos Thank you for your explanation. It's rock solid.

MrGreensWorkshop commented 1 year ago

Since French is added. I need to make some updates on this.

MrGreensWorkshop commented 1 month ago

I asked for a double check, but I didn't get many returns. I will go with the current state. There is always room for improvement. Please feel free to correct any of my mistakes.