Giscus is not working on Chinese language blog post pages - Githubissues

MrGreensWorkshop / MrGreen-JekyllTheme

Mr. Green is a multilingual theme generated with Jekyll and fully compatible with GitHub Pages.

https://jekyll-theme-mrgreen-demo.mrgreensworkshop.com

MIT License

155 stars 295 forks source link

Giscus is not working on Chinese language blog post pages #229

Closed MrGreensWorkshop closed 2 months ago

MrGreensWorkshop commented 2 months ago

Please check these items before go any further

[X] I have watched Mr. Green theme tutorials playlist on YouTube.
[X] I have searched the existing Issues.
[X] I have searched the existing Discussions.
[X] I have checked jekyll docs and the answer was not there.
[X] I have tested in one of these browsers; Safari, Chrome, Firefox. (This project hasn't been tested in other browsers.)

Are you sure this is a bug?

[X] I'm sure this is definitely a bug.

Describe the bug

Giscus is not working on Chinese language blog post pages Screenshot 2024-07-19 at 11 12 56

Expected Behavior

Giscus should be work on Chinese blog post pages.

Steps To Reproduce

Setup Giscus
Compile demo project
Open any blog post page
check if it is working.

Which browser have you used?

[X] Chrome
[X] Safari
[X] Firefox
[ ] Other browsers (This project hasn't been tested in other browsers.)

Which device have you used?

[X] Desktop
[ ] Mobile IOS
[ ] Mobile Android
[ ] Other platforms (This project hasn't been tested in other devices.)

Anything else?

According to Giscus, "zh" should be used with country "zh-CN" https://github.com/giscus/giscus/tree/main/locales

MrGreensWorkshop commented 2 months ago

fixed with #230.