search

MrGreensWorkshop / MrGreen-JekyllTheme

Mr. Green is a multilingual theme generated with Jekyll and fully compatible with GitHub Pages.
https://jekyll-theme-mrgreen-demo.mrgreensworkshop.com
MIT License
159 stars 296 forks source link

Fix LinkedIn social using incorrect default path and Update GitHub and Twitter to use canonical URL #67

Closed joshbuker closed 2 years ago

joshbuker commented 2 years ago

Similar to how YouTube uses /channel, LinkedIn uses /in as a prefix for profiles.

joshbuker commented 2 years ago

@MrGreensWorkshop I also noticed that GitHub and Twitter were using www. which isn't the canonical url (they'll redirect to github.com and twitter.com respectively). All the other social links are correct however (they all use www.).

MrGreensWorkshop commented 2 years ago

Related issues, #68 , #69, Thank your for your contribution, Next time, could you please create issue per PR? and split if required. Thank you for your understanding.

joshbuker commented 2 years ago

Next time, could you please create issue per PR?

Out of curiosity, why create a redundant issue for the PR? It seems like extra work for not much gain, but it could be I'm missing something.

MrGreensWorkshop commented 2 years ago

@joshbuker Yes, there are cases where there is extra work, but at some points it is necessary. For those who are new to the project, it is more understandable to look at the issue rather than PR's. Sometimes I wondered why I did such a thing after the changes made in PR. I'm in favor of managing the problem and solution separately. If you look at my previous PR's, you can see what I suggest in each PR for each issue there. I know it's not needed in situations like your PR's. But if there is no rule, people will prefer not to file any issues at all. That's why I added those issue and PR templates. One more thing, When I release a new version, It is easy to create release notes from issues. (New features and bugs.) I hope I could explain what I mean.