MrHackett / iui

Automatically exported from code.google.com/p/iui
MIT License
0 stars 0 forks source link

Add 'backwards' property to beforetransition events #252

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
I added a 'backwards' property to the beforetransition events. This extra
bit of information allows client code to handle scrolling to the
appropriate place when the back button is clicked. Instead of handling this
by changing iUI, as is done by the patch in issue #62, the 'backwards'
property allowed us this to be handled in an extension.

Note that the patch is based on a version of iUI after the documentation
patch (#251), so it maybe easier to apply the patches in that order.

-- Peter Rust
Developer, Cornerstone Systems

Original issue reported on code.google.com by PeterAndJessica@gmail.com on 3 Jun 2010 at 11:47

Attachments:

GoogleCodeExporter commented 8 years ago
I know that Max Melcher started work on some code to remember the position:
http://code.google.com/r/melchermaximilian-iui/source/detail?r=774198d1863f2cd25
d42809611b3450f88862bae

Is remembering and restoring scroll position something that should be done in 
core or a plugin?

Also, is the 'backwards' flag something that is generally useful?   (Probably.)

Max are you around?

Original comment by msgilli...@gmail.com on 11 Jun 2010 at 3:10

GoogleCodeExporter commented 8 years ago
I wouldn't have a need for the backwards flag if remembering the position was 
supported by the library, so I wouldn't include it if we're going to do that 
and no one else has a need for it.

Our code to remember the position doesn't work seamlessly (the 'from' page 
jumps to the scroll position of the 'to' page at the start of the transition) 
-- I don't know that it's possible to get around this with the architecture of 
the main iUI branch, but with the iScroll branch it should be fairly 
straightforward.

Original comment by PeterAndJessica@gmail.com on 11 Jun 2010 at 5:47

GoogleCodeExporter commented 8 years ago
I would like to get position remembering built in.  I'm also open to including 
the backwards flag if there are use cases for it.  This is something we 
definitely need  to look harder at...

So by "accepting" this bug I'm acknowledging the need for at least a mechanism 
to save position and possible for the general flag.  We may want to combine 
with (or at least reference) any other related issues.

Original comment by msgilli...@gmail.com on 11 Jun 2010 at 10:44