MrHertal / react-native-twilio-phone

Twilio Voice React Native module.
MIT License
154 stars 67 forks source link

Help wanted #30

Closed calz10 closed 3 years ago

calz10 commented 3 years ago

Hi @MrHertal , im not sure if this question suits here yet. would ask if this package could also have the connect method of twilioVoice?

same with this package: https://github.com/hoxfon/react-native-twilio-programmable-voice im planning to change the wrapper into your wrapper as it uses callkeep and im not quite sure if its possible also here. Thank you.

Referrence:

Screen Shot 2021-04-25 at 5 19 48 PM
calz10 commented 3 years ago

hi @MrHertal , have tried to fork your repo then updated the params. it dialed successfuly yet when user accepts the call it is not reflecting on the caller side that it have accepted the call. lol.will expirement if it would work. thans

Screen Shot 2021-04-25 at 8 52 55 PM
calz10 commented 3 years ago

ah its working lol i just use simulator then voice on same computer. thank you!

calz10 commented 3 years ago

Reopening this issue. maybe someone is looking for this too thanks. @MrHertal , hi your wrapper is great could you able allow extra params in startCall method? thanks

MrHertal commented 3 years ago

Hi,

You can use startCall on the lower API.

Here is the method signature:

startCall(accessToken: string, params: ConnectParams): void;

params is a key/value object that is passed to Twilio connect method.

calz10 commented 3 years ago

Hi @MrHertal, Have tried your suggestion yep working in development yet. when i try to release version and make a call im having crash on android note dev is fine , currently im on the latest rn version 0.64.0. Just wondering if you've tried it also on your release?

thank you. @MrHertal so i've got this log on bugsnag.

Screen Shot 2021-05-02 at 6 54 32 PM
calz10 commented 3 years ago

ah, nvm ill close this issue. the proguard just need to be updated as fixed. thanks @MrHertal