search

MrHertal / react-native-twilio-phone

Twilio Voice React Native module.
MIT License
153 stars 66 forks source link

avoid firebase messaging import on ios #96

Open heyalexchoi opened 2 years ago

heyalexchoi commented 2 years ago

ios project does not need firebase since that is only used for android. attempting to import firebase messaging in ios project breaks. issue. maybe this works if you actually install the pods and so on but there's a ton of subdependencies with special build configurations etc that I don't really want to deal with especially since that code will never even be called in an ios app.

this changes import of firebase messaging to conditional import since it is only conditionally used on android.

heyalexchoi commented 1 year ago

@MrHertal who should we get in touch with for this?