search

MrJCipherButtles / concordi_around

ConcordiaAround is a campus guide mobile application for Concordia University
0 stars 3 forks source link

Feature/popup ontap #150

Closed raffiJan closed 4 years ago

raffiJan commented 4 years ago

Added ability to tap on campus building markers and get the detail popup widget. This feature was added in reference to the request on #127.

EspressoCode commented 4 years ago

I would like to add to the pr description that you can LongPress (and not tap) on a building's name and see the popUp.

DiveshPatel commented 4 years ago

Just a reminder, long press on the icons to reveal the pop-up

codecov-io commented 4 years ago

Codecov Report

Merging #150 into master will decrease coverage by 2.46%. The diff coverage is 28.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   74.40%   71.94%   -2.47%     
==========================================
  Files          31       31              
  Lines        2575     2702     +127     
==========================================
+ Hits         1916     1944      +28     
- Misses        659      758      +99
Impacted Files Coverage Δ
lib/main.dart 0.00% <ø> (-50.00%) :arrow_down:
lib/provider/calendar_notifier.dart 0.00% <0.00%> (ø)
lib/view/calendar_page.dart 0.00% <0.00%> (ø)
lib/widget/building_popup.dart 17.27% <ø> (ø)
lib/widget/search/main_search_bar.dart 41.53% <0.00%> (ø)
lib/widget/drawer.dart 78.40% <12.50%> (-5.55%) :arrow_down:
lib/widget/map.dart 21.02% <23.21%> (-1.66%) :arrow_down:
lib/service/marker_helper.dart 46.62% <32.00%> (-15.03%) :arrow_down:
lib/model/building.dart 85.29% <66.66%> (-2.21%) :arrow_down:
lib/data/building_list.dart 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a0ad18...e9f7ad9. Read the comment docs.