Fixed some bugs - Githubissues

slava110 commented 3 years ago

Updated Gradle to 4.8.1
Updated Forge to 14.23.5.2847 and mappings snapshot_20171003
Removed ConfigSlurper from build.gradle (you can use gradle.properties)
Fixed #249 (Kawoosh able to destroy blocks marked as non-destructible)
Fixed #243 (Universe dialer crash) [Temporary fix]
Fixed #242 (Universe dialer crash) [Temporary fix]
Fixed #236 (Notebook crafting error) [Temporary fix]
Added Keyboard.enableRepeatEvents() to PageRenameGui (you can now hold buttons, yay)
Added kawoosh-invincible blocks to config

slava110 commented 3 years ago

Also here's mod jar https://github.com/slava110/AUNIS/releases/tag/1.9.11-beta

Universe dialer crash & notebook crafting marked as temporary as I'm thinking about using capabilities instead of NBT to store data. Should be safer. But I'll need to keep compatibility with old NBT system too

MrJake222 commented 3 years ago

Universe dialer crash & notebook crafting marked as temporary as I'm thinking about using capabilities instead of NBT to store data. Should be safer. But I'll need to keep compatibility with old NBT system too

Don't. Capabilities are so unpredictable on creative and I think it's beyond my control. See the capacitors, disappearing charge. Universe dialer would be much, much worse...

I'll look into it soon, thanks for your contribution. I'm worried about the mappings, I've changes them the way there were because I think OpenComputers (If I recall correctly) had some weird issues.

slava110 commented 3 years ago

Universe dialer crash & notebook crafting marked as temporary as I'm thinking about using capabilities instead of NBT to store data. Should be safer. But I'll need to keep compatibility with old NBT system too

Don't. Capabilities are so unpredictable on creative and I think it's beyond my control. See the capacitors, disappearing charge. Universe dialer would be much, much worse...

I'll look into it soon, thanks for your contribution. I'm worried about the mappings, I've changes them the way there were because I think OpenComputers (If I recall correctly) had some weird issues.

What exact issues could happen with capabilities? I only had an issue with capabilities and OpenComputers (on registration). Easy to fix tho And what exact issues you had with new mappings and OpenComputers? I've used same mappings for OCRocketry mod and had no issues :I

MrJake222 commented 3 years ago

What exact issues could happen with capabilities? I only had an issue with capabilities and OpenComputers (on registration). Easy to fix tho

Take fully charged Capacitor Bank in creative mode. Switch it around a bit in slots and It'll lose it's charge. Capabilities will reset.

And what exact issues you had with new mappings and OpenComputers? I've used same mappings for OCRocketry mod and had no issues :I

I don't remember exactly. But I think it crashed with no method found or something. Could be another mod though...

slava110 commented 3 years ago

Take fully charged Capacitor Bank in creative mode. Switch it around a bit in slots and It'll lose it's charge. Capabilities will reset.

Can't reproduce on forge 14.23.5.2855. Should I do it in my inventory or in container or... Stargate container?

I don't remember exactly. But I think it crashed with no method found or something. Could be another mod though...

Oh, ye, could happen with mods which are using old forge. Like LibVulpes. Easy to fix tho - you can use it as compileOnly (provided) dependency. However, I don't have any issues with AUNIS project + old mappings currently

MrJake222 commented 3 years ago

Thank you for your pull request <3 Sadly, I don't have much time these days, but that may change in February... Btw, making each fix a separate commit simplifies reviewing changes a lot.

Should I do it in my inventory

Inventory.

MrJake222 / AUNIS

Fixed some bugs #250