search

MrJake222 / AUNIS

Stargate-inspired Minecraft Mod
GNU General Public License v3.0
44 stars 20 forks source link

Crash when aborting dial using Universe Dialer #269

Closed ghost closed 3 years ago

ghost commented 3 years ago

Ran into a bug with all current versions of the alpha branch, if you begin to dial using the Universe Dialer and then abort at any stage of the dial, the world will crash and will crash with every attempt to reload. This was a singleplayer test world with only aunis installed: crash-2021-01-25_22.37.59-server.txt

MrJake222 commented 3 years ago

Can you upload the crashing world here?

ghost commented 3 years ago

I don't have the exact world that log was pulled from as I deleted and remade the worlds several times to test but the bug is easily reproducible. New World.zip

MrJake222 commented 3 years ago

https://github.com/MrJake222/AUNIS/blame/master/src/main/java/mrjake/aunis/tileentity/stargate/StargateAbstractBaseTile.java#L555-L557 @slava110? The gate fails to dial and you add a task on the (even possibly non-exisisting) gate?

slava110 commented 3 years ago

The gate fails to dial and you add a task on the (even possibly non-exisisting) gate?

IIRC I've added it because gate chevrons on second gate remain turned on after dialing failed. But forgot to add check for address

MrJake222 commented 3 years ago

@slava110 have a look at the commit above. The thing is the incomingWormhole should never reach the target gate (when the dialing is destined to fail, for ex. not enough power). Find me a testing case when I can develop a nice system for this corner-case.