search

MrJake222 / AUNIS

Stargate-inspired Minecraft Mod
GNU General Public License v3.0
44 stars 19 forks source link

fix: regenerate addressess and update merge state when gate position changes #310

Open sentialx opened 3 years ago

sentialx commented 3 years ago

This PR should fix issues when moving the gate by using mods like WarpDrive, Valkyrien etc.

Nine chevron address stays the same when the gate moves and seven chevron address regenerates.

Fixes #253

MrJake222 commented 3 years ago

Won't it spam StargateNetwork with old addresses not pointing to valid gates? You don't seem to remove old addresses from the mapping.

You can query those with /sgquery command.

sentialx commented 3 years ago

My generateAddresses function calls the setGateAddress function which seems to remove the old address: https://github.com/sentialx/AUNIS/blob/c45f70404750b76da843888da99235b5db017c59/src/main/java/mrjake/aunis/tileentity/stargate/StargateAbstractBaseTile.java#L422

MrJake222 commented 3 years ago

Okay, didn't remember that one

HaleonGoemea commented 3 years ago

I would be willing to test, but idk how to turn this into a .class file. I have figured out that's what I need to do, but it always errors.

I apologize if it's rude to comment here, and will delete if so

MrJake222 commented 3 years ago

I would be willing to test, but idk how to turn this into a .class file. I have figured out that's what I need to do, but it always errors.

I apologize if it's rude to comment here, and will delete if so

Run ./gradlew build and search in build/libs for a .jar file.