search

MrJake222 / AUNIS

Stargate-inspired Minecraft Mod
GNU General Public License v3.0
44 stars 19 forks source link

Crash on Orlin's gate rendering #316

Open slava110 opened 3 years ago

slava110 commented 3 years ago

Crash log: https://paste.ee/p/1Iof4 Cause: mrjake.aunis.block.stargate.StargateAbstractMemberBlock#L111

slava110 commented 3 years ago

Should be moved to StargateClassicMemberBlock probably as there's no camouflage for abstract stargate at all

MrJake222 commented 3 years ago

Also probably when rendering block it should return something different than UNDEFINED

slava110 commented 3 years ago

Available values

MrJake222 commented 3 years ago

Probably we should somehow get the default FaceShape of the stock block used, which is probably going to be always solid

slava110 commented 3 years ago

Why? If you have SOLID faceshape people will be able to place torches, redstone on this side of your block. It will look kinda weird on stargate. We can return SOLID for bottom of Orlin's gate tho (because it looks like full block IIRC)

MrJake222 commented 3 years ago

when rendering block

When stargate base/member is not merged it is rendered as ordinary block. Then it should probably be able to support snow/torches/etc.

slava110 commented 3 years ago

When stargate base/member is not merged it is rendered as ordinary block. Then it should probably be able to support snow/torches/etc.

Then you will need to update all stargate blocks when stargate will be merged. Otherwise torches/snow will stay on stargate after merging

MrJake222 commented 3 years ago

Hmm. There is already a field in members whether a gate is merged or not, so what's the problem?

slava110 commented 3 years ago

No problem, just saying that you'll need to update block too. Via world.scheduleBlockUpdate or something like that. Otherwise snow/torches will stay on the block because they will not check if BlockFaceShape has been changed