search

MrKacafirekCZ / doggo-mod-overhauled

Doggo Mod Overhauled is a Minecraft mod that just makes dogs better.
GNU General Public License v3.0
5 stars 5 forks source link

Fix WolfEntityMixin so it doesn't break mixins into the same class from other mods #28

Closed Fuzss closed 10 months ago

Fuzss commented 1 year ago

A fix for #23. This is easier to change on your end as you don't necessarily need your injection to happen before the wolf is tamed while I do (since I want to prevent it). The issue itself shouldn't really happen, but that comes down to the mixin framework itself.

Moving the injection here to after the taming doesn't make a difference as the vanilla wolf is discarded anyway.

Fuzss commented 1 year ago

After some more testing it turns out the injection point wasn't the issue.

Overriding Tameable::method_48926 is what actually breaks it, I'd assume maybe due to some mapping issue, not sure though. Anyway, you do not need to implement abstract methods in a mixin class, just make the mixin class itself abstract.

MrKacafirekCZ commented 10 months ago

LGTM