search

MrKai77 / Loop

Window management made elegant.
GNU General Public License v3.0
6.49k stars 122 forks source link

🐞 Loop is firing with the wrong keybinding #509

Open saminton opened 1 month ago

saminton commented 1 month ago

Bug Description

I've set up some keybindings as Ctrl + Cmd + Arrow key but they are sometimes being fired when only pressing Cmd + Arrow key

Steps To Reproduce

Set up custom key binding as so, I am also using cycles but I'm not sure if this is needed to recreate the bug Screenshot 2024-07-15 at 11 52 16

I can get this bug to happen pretty consistently by doing the following :

  1. Use Ctrl + Arrow key (I have this set up to change macOs desktops)
  2. Select a text field on any application (vscode, chrome, textedit...)
  3. Use Cmd + Arrow key and it fires Loop

Expected Behavior

It should only fire loop when using the designated shortcut

Actual Behavior

Loop is firing with the wrong keybinding

Screenshots

No response

MacOS Version

Sonoma 14.5 (23F79)

Loop Version

Version 1.0.0 (1030)

Additional Context

No response

Final Checks

SenpaiHunters commented 1 month ago

Huh? Can you send over your keybinds? As have almost the same keys and use the trigger key, and Loop's never misfired for me. Also, you can toggle the button to use developmental builds (if you do not see this, you'll need to manually download this and use the developmental build) and use https://github.comrKai77/Loop/releases/tag/prerelease prerelease version, first check with the prerelease version if this bug still happens, and if it does, send over your keybinds so I can debug further.

saminton commented 1 month ago

@SenpaiHunters I have just downloaded the dev build but the problem is still occurring. How do you want me to send you the keybindings ? Is there a someway to export them ?

SenpaiHunters commented 1 month ago

Yep, open Loop > Advanced > Keybinds > Export and send that JSON file here.

saminton commented 1 month ago

Here they are keybinds.json

SenpaiHunters commented 1 month ago

Alright, after trying to trigger and replicate it with your steps, I cannot get Loop to misfire, no matter what I do. Can you record a video of this misfiring and send it in here? Another thing I recommend you do is remove Loop from the accessibility list, quit Loop, then reopen Loop, and when prompted for permissions, reset them. After that, try again and see if it still has any issues. Also, ensure you do not have something else in the background using the other key or that you are not bumping it.

SenpaiHunters commented 1 month ago

Hey, @saminton, I am back after 2 weeks.

  1. Have you updated to version 1.1.1? If not, please do so.
  2. Can you still repo this issue (on a newer build)
saminton commented 2 weeks ago

I can't seem to replicate this on another computer either so I'm guessing it's either a conflict with some other software I have installed but I can't figure out what or my macOs installation is playing up, I'll have to try with a clean macOs install