🐞 Icon for Cycles - Githubissues

MrKai77 / Loop

Window management made elegant.

GNU General Public License v3.0

7.14k stars 144 forks source link

🐞 Icon for Cycles #597

Open ShawnZhong opened 1 month ago

ShawnZhong commented 1 month ago

Bug Description

I am not sure what the expected icon for cycles is. It seems to be pretty random right now.

Steps To Reproduce

Add a new cycle: the initial icon is an empty box
Click "Add"
Select an action, say "Fullscreen": the icon is still empty
Click "Add" again: the icon shows fullscreen
Select another action, say "Center": the icon now becomes empty again
Remove the "Center" action: the icon now shows "Center", which does not exist at this point

Expected Behavior

I am not sure.

Actual Behavior

See below

Screenshots

Untitled

macOS Version

15.1 Beta

Loop Version

1.2.0 (1356)

Additional Context

No response

Final Checks

[X] My issue is written in English
[X] My issue title is descriptive
[X] This is a single bug (multiple bugs should be reported individually)
[X] I can help with fixing or developing this issue (tick if you can help).

MrKai77 commented 1 month ago

Interesting, the intended behavior for the cycle icon is to reflect the first action inside the cycle, but I can see that is not happening in your ticket 🤔 I'm guessing that this is a bug caused by a missing change observer for the keybind value, which causes the icon to not be updated in real time.