Natron 2/3: use project variables in cache hash computation

MrKepzie / Natron

Open-source compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.

www.natron.fr

GNU General Public License v2.0

1.49k stars 163 forks source link

Natron 2/3: use project variables in cache hash computation #1672

Closed devernay closed 7 years ago

devernay commented 7 years ago

two reader with the same input filename (eg [Project]/input.png) but different values for [Project] will be stored in the same cache entry, resulting in rendering bugs (see the TestNormalize unit test).

Two solutions:

compute a "project hash" from all variables in the project, and prepend it to all cache hashes
substitute all variables in string parameters before computing the hash

This probably also affects Natron 2 (to a lesser extent)

devernay commented 7 years ago

fixed by 09bbe85193165d45aa2ac2c9dc949cbf2b2465c0