MrKepzie / Natron

Open-source compositing software. Node-graph based. Similar in functionalities to Adobe After Effects and Nuke by The Foundry.
www.natron.fr
GNU General Public License v2.0
1.49k stars 164 forks source link

Color Correction Master saturation overrides Highlight and shadow #1706

Closed RichardULZ closed 6 years ago

RichardULZ commented 6 years ago

Problem

On the Color Correction node, Master saturation will not work as expected with highlight and shadow adjustments.

Expected behavior: Using the Master saturation at the same time as highlights and shadow controls, master saturation should act the same as creating a saturation node after highlight and shadow adjustment.

Actual behavior: If master saturation is 0, highlight and shadow will be disabled, if saturation is above 1, the highlight and shadow effect is multiplied.

Steps to Reproduce

  1. Create a Color Wheel with edge value 0
  2. Create a Color Correct node and set the highlight gain to 0 and Shadow gain to 4
  3. Change the master saturation between 0 and 4.

Bringing saturation to 0 will fade off the highlight correction. Bringing saturation to 2 will multiply the power of highlight correction.

The example file has 2 outputs, the right is the steps mentioned above, the left is doing highlights on one node, and saturation on another node afterwards.

sat CCSaturationntp.zip

(might be a tad trickier than clamped ranges... good luck)

Versions

devernay commented 6 years ago

fixed in the next snapshot