search

MrKinau / FishingBot

1.8 - 1.21 Fishing bot for Minecraft
GNU General Public License v3.0
322 stars 68 forks source link

1.17.1 Support #138

Closed neuron42 closed 3 years ago

JustZacTTv commented 3 years ago

this would be bussin

nutjob4life commented 3 years ago

I gave it a shot @MrKinau, adding the bare minimum to support 1.17.1 in the hopes that there were no changes in the protocol for fishing in 1.17.1 (based on your 1.17 branch). But no dice:

java.lang.IllegalStateException: java.io.EOFException 
    at com.google.common.io.ByteStreams$ByteArrayDataInputStream.readLong(ByteStreams.java:351) 
    at systems.kinau.fishingbot.network.utils.ByteArrayDataInputWrapper.readLong(ByteArrayDataInputWrapper.java:116) 
    at systems.kinau.fishingbot.network.protocol.Packet.readUUID(Packet.java:96)

So I guess there were some changes! 😊

Anyway, if this is something you could poke around in, I'd sure be grateful—as would @neuron42 and @JustZacTTv 😄

nutjob4life commented 3 years ago

Ooo, I think I saw some good news on Discord … which brought me here.

$ git pull
$ mvn package
$ java -jar target/FishingBot-2.7.16.jar
[2021-07-21 20:44:40] [INFO   ] Using FishingBot v2.7.16 
…
[2021-07-21 20:45:47] [INFO   ] I start to fish! 
[2021-07-21 20:46:15] [INFO   ] Caught "cod" 
[2021-07-21 20:46:34] [INFO   ] Caught "cod" 
[2021-07-21 20:46:42] [INFO   ] Caught "pufferfish"

Looks pretty good so far 🥳

MrKinau commented 3 years ago

Yeah 1.17.1 is fully supported now! 🥳