MrKinau / FishingBot

1.8 - 1.21 Fishing bot for Minecraft
GNU General Public License v3.0
322 stars 68 forks source link

1.18 Support #156

Closed nutjob4life closed 2 years ago

nutjob4life commented 2 years ago

📜 Summary

Minecraft 1.18 got released on 2021-11-30. It'd be super if FishingBot could support it.

🩺 Steps to Reproduce

$ date -u
Wed Dec  1 00:40:13 UTC 2021
$ java -jar FishingBot-2.7.17.jar -config my-config.json -nogui
[2021-11-30 18:40:17] [INFO   ] Using FishingBot v2.7.17 
[2021-11-30 18:40:17] [INFO   ] Using language: ENGLISH @ /lang/fb_en.properties 
[2021-11-30 18:40:17] [INFO   ] Configuration was loaded: my-config.json 
[2021-11-30 18:40:17] [INFO   ] Trying to authenticate using access token... 
[2021-11-30 18:40:18] [WARNING] The access token is irrecoverably. Using password authentication. 
[2021-11-30 18:40:18] [INFO   ] Trying to authenticate with ************@[REDACTED]:************ (MICROSOFT)... 
[2021-11-30 18:40:22] [INFO   ] Authentication successful! 
[2021-11-30 18:40:22] [INFO   ] Username: [REDACTED]
[2021-11-30 18:40:22] [INFO   ] The terms of service for realms have been accepted! 
[2021-11-30 18:40:23] [INFO   ] Connecting to realm {"address":"20.67.212.217:30040","resourcePackHash":null,"resourcePackUrl":null}... 
[2021-11-30 18:40:23] [INFO   ] Pinging 20.67.212.217:30040 with protocol of MC-1.17.1 
[2021-11-30 18:40:23] [SEVERE ] The server 20.67.212.217 is not reachable with the Minecraft version. The automatic version detection may not work. Please set a default-protocol in config.json. 
[2021-11-30 18:40:23] [INFO   ] systems.kinau.fishingbot.network.utils.InvalidPacketException: VarInt too big 
[2021-11-30 18:40:23] [INFO   ]     at systems.kinau.fishingbot.network.protocol.Packet.readVarInt(Packet.java:120) 
[2021-11-30 18:40:23] [INFO   ]     at systems.kinau.fishingbot.network.ping.ServerPinger.ping(ServerPinger.java:73) 
[2021-11-30 18:40:23] [INFO   ]     at systems.kinau.fishingbot.Bot.<init>(Bot.java:248) 
[2021-11-30 18:40:23] [INFO   ]     at systems.kinau.fishingbot.FishingBot.startBot(FishingBot.java:80) 
[2021-11-30 18:40:23] [INFO   ]     at systems.kinau.fishingbot.Main.main(Main.java:59) 
[2021-11-30 18:40:23] [INFO   ] Module "HandshakeModule" enabled! 
[2021-11-30 18:40:23] [INFO   ] Module "LoginModule" enabled! 
[2021-11-30 18:40:23] [INFO   ] Module "ClientDefaultsModule" enabled! 
[2021-11-30 18:40:23] [INFO   ] Module "FishingModule" enabled! 
[2021-11-30 18:40:23] [INFO   ] Module "ChatProxyModule" enabled! 
[2021-11-30 18:40:23] [INFO   ] Module "ChatCommandModule" enabled! 
[2021-11-30 18:40:23] [INFO   ] Module "EjectionModule" enabled! 
[2021-11-30 18:40:23] [SEVERE ] Login failed: {"translate":"multiplayer.disconnect.incompatible","with":["1.18"]} 
$ echo \U+1F626
😦

😌 Gratitude

From a Patreon Sponsor of this project, you have my thanks in advance for supporting this project and addressing this issue.

MrKinau commented 2 years ago

Thank you for pointing this out and your general support. I've created a new release, which adds support for 1.18 (luckily Mojang decided to make the updating process fairly easy this time :) )

nutjob4life commented 2 years ago

Thank you @MrKinau! Glad the protocol and behavior wasn't vastly different.

Well, back to the fishing pier we go!